From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Sean Paul <sean@poorly.run>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Jie Zhang <jie.zhang@oss.qualcomm.com>
Subject: Re: [PATCH v2 3/6] dt-bindings: display/msm/rgmu: Document A612 RGMU
Date: Thu, 13 Nov 2025 09:11:27 +0100 [thread overview]
Message-ID: <559f1531-f97e-4927-b4ba-86a51262bef5@kernel.org> (raw)
In-Reply-To: <07221941-4546-4153-b845-594be006e79a@oss.qualcomm.com>
On 11/11/2025 15:51, Akhil P Oommen wrote:
>>> + - |
>>> + #include <dt-bindings/clock/qcom,qcs615-gpucc.h>
>>> + #include <dt-bindings/clock/qcom,qcs615-gcc.h>
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> + #include <dt-bindings/power/qcom,rpmhpd.h>
>>> +
>>> + rgmu: rgmu@506a000 {
>>
>> Drop label.
>>
>> Node names should be generic. See also an explanation and list of
>> examples (not exhaustive) in DT specification:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>> If you cannot find a name matching your device, please check in kernel
>> sources for similar cases or you can grow the spec (via pull request to
>> DT spec repo).
>
> I guess we can use 'gmu' here as that name is already in use for other
> chipsets?
>
> Ack for all other suggestions. Will update the patch.
Yes, then let's just use existing gmu.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-13 8:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 20:50 [PATCH v2 0/6] Support for Adreno 612 GPU - Respin Akhil P Oommen
2025-11-06 20:50 ` [PATCH v2 1/6] drm/msm/a6xx: Add support for Adreno 612 Akhil P Oommen
2025-11-07 8:58 ` Konrad Dybcio
2025-11-11 15:10 ` Akhil P Oommen
2025-11-12 9:59 ` Konrad Dybcio
2025-11-06 20:50 ` [PATCH v2 2/6] dt-bindings: display/msm: gpu: Document A612 GPU Akhil P Oommen
2025-11-10 7:48 ` Krzysztof Kozlowski
2025-11-14 11:58 ` Akhil P Oommen
2025-11-06 20:50 ` [PATCH v2 3/6] dt-bindings: display/msm/rgmu: Document A612 RGMU Akhil P Oommen
2025-11-10 7:51 ` Krzysztof Kozlowski
2025-11-11 14:51 ` Akhil P Oommen
2025-11-13 8:11 ` Krzysztof Kozlowski [this message]
2025-11-14 12:00 ` Akhil P Oommen
2025-11-14 12:08 ` Akhil P Oommen
2025-11-14 12:16 ` Krzysztof Kozlowski
2025-11-06 20:50 ` [PATCH v2 4/6] arm64: dts: qcom: sm6150: add the GPU SMMU node Akhil P Oommen
2025-11-06 20:50 ` [PATCH v2 5/6] arm64: dts: qcom: sm6150: Add gpu and rgmu nodes Akhil P Oommen
2025-11-07 9:01 ` Konrad Dybcio
2025-11-10 10:42 ` Akhil P Oommen
2025-11-06 20:50 ` [PATCH v2 6/6] arm64: dts: qcom: qcs615-ride: Enable Adreno 612 GPU Akhil P Oommen
2025-11-07 8:52 ` [PATCH v2 0/6] Support for Adreno 612 GPU - Respin Konrad Dybcio
2025-11-10 10:46 ` Akhil P Oommen
2025-11-10 14:34 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559f1531-f97e-4927-b4ba-86a51262bef5@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=akhilpo@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=jie.zhang@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).