From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v3 2/4] dt-bindings: brcmstb-gpio: document properties for wakeup Date: Mon, 13 Jul 2015 10:35:57 -0700 Message-ID: <55A3F6FD.1070006@broadcom.com> References: <1434589243-502-1-git-send-email-gregory.0xf0@gmail.com> <1434589243-502-3-git-send-email-gregory.0xf0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij , Gregory Fong , Grant Likely , Bjorn Helgaas , Rob Herring Cc: "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Alexandre Courbot , bcm-kernel-feedback-list , Brian Norris , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Florian Fainelli , Ian Campbell , Kumar Gala , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mark Rutland , Pawel Moll , Russell King List-Id: devicetree@vger.kernel.org On 13/07/15 05:29, Linus Walleij wrote: > On Thu, Jun 18, 2015 at 3:00 AM, Gregory Fong wrote: >=20 >> Some brcmstb GPIO controllers can be used to wake from suspend, so u= se >> the de facto standard property 'wakeup-source' to mark the nodes of >> controllers with that capability. >> >> Also document interrupts-extended, which will be used for wakeup >> handling because the interrupt parent for the wake IRQ is different >> from the regular IRQ. >> >> While we're at it, a few more fixes: We don't actually use the >> "interrupt-names" property, so remove it from the listed optional >> properties and from the examples. And since we're modifying the >> examples, also follow Brian's suggestions to: >> - change #gpio-cells, #interrupt-cells, and brcm,gpio-bank-widths fr= om >> hex to dec >> - use phandles >> >> Reviewed-by: Brian Norris >> Signed-off-by: Gregory Fong >> --- >> v3: Update per Brian's suggestions described in above message. >=20 > I'm very uncertain regarding these interrupts-extended etc. Gregory's additions to the binding are correct and comply with how the 'interrupts-extended' property is meant to be used. FYI, this is required because most wake-up capable HW on brcmstb chips have N interrupts feeding to a GIC, but their wake-up interrupt(s) feed to an always-on interrupt controller. With the 'interrupts' + 'interrupt-parent' property, you can "cross" multiple interrupt domains= =2E The precedence and rules for interpreting the "legacy" interrupts property vs. interrupts-extended is documented in the tree. >=20 > Can someone who understands that ACK this? Acked-by: Florian Fainelli >=20 > E.g. Grant Likely, Bj=C3=B6rn Helgaas, Rob Herring. >=20 > Yours, > Linus Walleij >=20 --=20 =46lorian -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html