From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect Date: Wed, 15 Jul 2015 18:05:59 +0530 Message-ID: <55A653AF.608@ti.com> References: <1436366500-12555-1-git-send-email-hdegoede@redhat.com> <1436366500-12555-2-git-send-email-hdegoede@redhat.com> Reply-To: kishon-l0cyMroinI0@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1436366500-12555-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede , Felipe Balbi Cc: Chanwoo Choi , Maxime Ripard , Chen-Yu Tsai , Roman Byshko , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote: > sun4i_usb_phy_set_squelch_detect is used by other code, which may be built > as a module, so it should be exported. > > Signed-off-by: Hans de Goede > --- > Changes in v6: > -New patch in v6 of the sunxi musb support series > --- > drivers/phy/phy-sun4i-usb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c > index e17c539..b82aa26 100644 > --- a/drivers/phy/phy-sun4i-usb.c > +++ b/drivers/phy/phy-sun4i-usb.c > @@ -212,6 +212,7 @@ void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, bool enabled) > > sun4i_usb_phy_write(phy, PHY_SQUELCH_DETECT, enabled ? 0 : 2, 2); > } > +EXPORT_SYMBOL(sun4i_usb_phy_set_squelch_detect); EXPORT_SYMBOL_GPL? Thanks Kishon