From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the DT binding Date: Fri, 17 Jul 2015 08:46:22 +0200 Message-ID: <55A8A4BE.1030904@osg.samsung.com> References: <1437114567-17629-1-git-send-email-javier@osg.samsung.com> <1437114567-17629-5-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: Lee Jones , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sergei Shtylyov , Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hello Krzysztof, On 07/17/2015 08:42 AM, Krzysztof Kozlowski wrote: > 2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas : >> The Maxim MAX77686 PMIC is a multi-function device with regulators, >> clocks and a RTC. The DT bindings for the clocks are in a separate >> file but the bindings for the regulators are inside the mfd part. >> >> To make it consistent with the clocks portion of the binding and >> because is more natural to look for regulator bindings under the >> bindings/regulator sub-directory, split the regulator portion of >> the DT binding and add it as a separate file. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> Changes in v2: >> - Use a generic name for the max77686 node in the regulator example. >> >> Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- >> .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ >> 2 files changed, 74 insertions(+), 55 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt > > Putting regulator bindings under regulator directory seems logical so > I am fine with it. > > Reviewed-by: Krzysztof Kozlowski > Thanks a lot for your review. For completeness, I talked with Lee Jones over IRC yesterday asking him his opinion on whether MFD DT binding doc should contain all the info or if it should be split across different subsystems and he prefers the later. That's why I re-spun this series. > Best regards, > Krzysztof > -- Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America