From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v3 2/2] ARM: dts: vf-colibri: Add property for minimum sample time Date: Sun, 19 Jul 2015 13:44:55 +0100 Message-ID: <55AB9BC7.9040408@kernel.org> References: <20e2cfad3fbb1a45332e9936ea493ddc8bfaf51d.1436880513.git.maitysanchayan@gmail.com> <20150715015725.GK4119@tiger> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Agner , Shawn Guo Cc: Sanchayan Maity , mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 15/07/15 14:02, Stefan Agner wrote: > On 2015-07-15 03:57, Shawn Guo wrote: >> On Tue, Jul 14, 2015 at 07:23:23PM +0530, Sanchayan Maity wrote: >>> Add a device tree property which allows to specify the minimum sample >>> time which can be used to calculate the actual ADC cycles required >>> depending on the hardware. >>> >>> Signed-off-by: Sanchayan Maity >>> --- >>> arch/arm/boot/dts/vf-colibri.dtsi | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi >>> index ab10d2e..59f5deb 100644 >>> --- a/arch/arm/boot/dts/vf-colibri.dtsi >>> +++ b/arch/arm/boot/dts/vf-colibri.dtsi >>> @@ -16,10 +16,12 @@ >>> }; >>> >>> &adc0 { >>> + min-sample-time = <1000>; >>> status = "okay"; >>> }; >>> >>> &adc1 { >>> + min-sample-time = <1000>; >> >> Since this is the default value anyway, we can just save the patch, >> right? > > I thought it would be nice to be explicit here and define this value > which we verified internally. > > On the other hand, we did not derived the minimum value from the DS > (using the capacity/resistance of the actual analog source connected) to > maximize the sampling frequency, hence I'm also ok with not explicitly > defining a value. I'll drop this patch then and we are all happy (I think) > > -- > Stefan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >