devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: Moritz Fischer <moritz.fischer@ettus.com>, p.zabel@pengutronix.de
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux@arm.linux.org.uk, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, michal.simek@xilinx.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, galak@codeaurora.org,
	soren.brinkmann@xilinx.com,
	Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller.
Date: Mon, 27 Jul 2015 08:56:45 +0200	[thread overview]
Message-ID: <55B5D62D.4010407@monstr.eu> (raw)
In-Reply-To: <1437783682-13632-3-git-send-email-moritz.fischer@ettus.com>

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Hi Moritz,

On 07/25/2015 02:21 AM, Moritz Fischer wrote:
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  arch/arm/boot/dts/zynq-7000.dtsi            | 43 ++++++++++++-

This patch is nice in general but every change in binding should be
discussed separately. There is also necessary to wire them up in the
driver to do action. That's why I think that will be the best just to
add the code to slcr and keep others untouched.

For example MACB/GEM is one example. Adding names to this node and
extending driver to work properly with reset means that all others MACB
users will be affected. Definitely this patch should be ACKed by Nicolas.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2015-07-27  6:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-25  0:21 [RFCv2 0/3] Adding support for Zynq Reset Controller Moritz Fischer
2015-07-25  0:21 ` [RFCv2 1/3] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings Moritz Fischer
2015-07-27  5:09   ` Michal Simek
     [not found]     ` <55B5BD08.60802-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2015-07-28  4:55       ` Moritz Fischer
     [not found]         ` <CAAtXAHeWtXVe4c5z_6AxMS0CggA2pN57mNArJsKG9=QxWs-zRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-28  5:41           ` Michal Simek
2015-07-28  2:58   ` Sören Brinkmann
2015-07-28  4:52     ` Moritz Fischer
2015-07-28 22:53       ` Sören Brinkmann
2015-07-29  6:14         ` Moritz Fischer
     [not found]           ` <CAAtXAHd8kG_FtKTW-2T2KToXesWgsgxkZ3vpXZ_oRjGCSfpFgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-29 17:38             ` Sören Brinkmann
2015-07-30 14:37               ` Michal Simek
2015-07-28  8:05   ` Philipp Zabel
     [not found]     ` <1438070702.3193.4.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-07-28  8:25       ` Michal Simek
2015-07-28 13:57         ` Moritz Fischer
     [not found]           ` <CAAtXAHc=WTg3VHugKZ+SHnCA7OKXLLay-aOJyk9C9r+Z2MWwBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-28 15:16             ` Philipp Zabel
2015-07-25  0:21 ` [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller Moritz Fischer
2015-07-27  6:56   ` Michal Simek [this message]
     [not found]     ` <55B5D62D.4010407-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2015-07-28  5:03       ` Moritz Fischer
2015-07-28  5:42         ` Michal Simek
     [not found]         ` <CAAtXAHepDRbiiznHnT3dLLLWS_VH2a9BhnNgZzDECx__QceEeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-28  6:59           ` Nicolas Ferre
     [not found]             ` <55B72857.3020108-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-07-28  7:44               ` Michal Simek
2015-07-28 13:54                 ` Moritz Fischer
2015-07-25  0:21 ` [RFCv2 3/3] reset: reset-zynq: Adding support " Moritz Fischer
     [not found]   ` <1437783682-13632-4-git-send-email-moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org>
2015-07-27  5:14     ` Michal Simek
2015-07-27  7:12     ` Michal Simek
     [not found]       ` <55B5D9C2.60509-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2015-07-28  4:59         ` Moritz Fischer
2015-07-28  5:43           ` Michal Simek
2015-07-28  8:38     ` Philipp Zabel
     [not found]       ` <1438072680.3193.24.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-07-28 14:05         ` Moritz Fischer
2015-07-28 14:27           ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B5D62D.4010407@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=moritz.fischer@ettus.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).