From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller. Date: Tue, 28 Jul 2015 08:59:35 +0200 Message-ID: <55B72857.3020108@atmel.com> References: <1437783682-13632-1-git-send-email-moritz.fischer@ettus.com> <1437783682-13632-3-git-send-email-moritz.fischer@ettus.com> <55B5D62D.4010407@monstr.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Moritz Fischer , Michal Simek Cc: p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, Michal Simek , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel , Kumar Gala , =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= List-Id: devicetree@vger.kernel.org Le 28/07/2015 07:03, Moritz Fischer a =C3=A9crit : > Hi Michal, >=20 > I agree we need to be careful with changing the bindings. >=20 > On Sun, Jul 26, 2015 at 11:56 PM, Michal Simek wro= te: >> Hi Moritz, >> >> On 07/25/2015 02:21 AM, Moritz Fischer wrote: >>> Signed-off-by: Moritz Fischer >>> --- >>> arch/arm/boot/dts/zynq-7000.dtsi | 43 ++++++++++++- >> >> This patch is nice in general but every change in binding should be >> discussed separately. There is also necessary to wire them up in the >> driver to do action. That's why I think that will be the best just t= o >> add the code to slcr and keep others untouched. >=20 > Ok, just to clarify: You'd suggest to just add the rstc as child node > to the slcr, > and leave the other nodes untouched? >=20 >> >> For example MACB/GEM is one example. Adding names to this node and >> extending driver to work properly with reset means that all others M= ACB >> users will be affected. Definitely this patch should be ACKed by Nic= olas. Actually, I don't know why a reset property should be added to the macb driver... Bye, --=20 Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html