devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/7] ARM: dts: ifc6410: Add pwrseq support for WLAN
Date: Wed, 29 Jul 2015 15:55:00 -0700	[thread overview]
Message-ID: <55B959C4.2090600@codeaurora.org> (raw)
In-Reply-To: <1438088022-17350-1-git-send-email-srinivas.kandagatla@linaro.org>

On 07/28/2015 05:53 AM, Srinivas Kandagatla wrote:
> +
> +		sdcc4_pwrseq:pwrseq {

Missing space here between label and node name.

> +			compatible = "mmc-pwrseq-simple";
> +			reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>;
> +		};
> +

Also this node is not part of the SoC so it should be in the root, 
possibly under some sort of power-sequences node so that all the 
sequences are grouped in one place.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-07-29 22:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 12:52 [PATCH v1 0/7] DT: APQ8064 for qcom-dt-next Srinivas Kandagatla
2015-07-28 12:53 ` [PATCH v1 1/7] ARM: dts: ifc6410: Add pwrseq support for WLAN Srinivas Kandagatla
2015-07-29 22:55   ` Stephen Boyd [this message]
2015-08-07  9:32     ` Srinivas Kandagatla
2015-07-30  0:12   ` Bjorn Andersson
2015-07-28 12:53 ` [PATCH v1 2/7] ARM: dts: qs600: add pwrseq support to WLAN Srinivas Kandagatla
2015-07-28 12:54 ` [PATCH v1 3/7] ARM: dts: apq8064-ifc6410: add heart-beat led support Srinivas Kandagatla
2015-07-28 17:36   ` Andreas Färber
2015-07-29 14:02     ` Srinivas Kandagatla
2015-07-28 12:54 ` [PATCH v1 4/7] ARM: dts: apq8064: Add MDP support Srinivas Kandagatla
2015-07-28 17:31   ` Andreas Färber
2015-07-28 18:30     ` Rob Clark
     [not found]   ` <1438088049-17479-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-08-06  1:27     ` Stephen Boyd
     [not found]       ` <55C2B801.1030806-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-08-07  1:19         ` Rob Clark
2015-07-28 12:54 ` [PATCH v1 5/7] ARM: dts: ifc6410: enable " Srinivas Kandagatla
2015-07-28 12:54 ` [PATCH v1 6/7] ARM: dts: qs600: " Srinivas Kandagatla
2015-07-28 12:54 ` [PATCH v1 7/7] ARM: dts: ifc6410: add inforce LVDS panel support Srinivas Kandagatla
2015-07-28 17:50   ` Andreas Färber
     [not found]     ` <55B7C0DC.2010501-l3A5Bk7waGM@public.gmane.org>
2015-07-28 18:47       ` Rob Clark
2015-07-29  5:39   ` Archit Taneja
     [not found]     ` <55B86710.4090507-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-07-29 14:03       ` Srinivas Kandagatla
2015-07-29 22:46   ` Stephen Boyd
2015-08-07  9:41     ` Srinivas Kandagatla
2015-08-10 23:25   ` Bjorn Andersson
2015-08-11  0:40     ` Rob Clark
2015-07-29  4:56 ` [PATCH v1 0/7] DT: APQ8064 for qcom-dt-next Andy Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B959C4.2090600@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).