devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
To: balbi-l0cyMroinI0@public.gmane.org
Cc: rogerq-l0cyMroinI0@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	t-kristo-l0cyMroinI0@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	nsekhar-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe
Date: Wed, 5 Aug 2015 19:42:24 +0530	[thread overview]
Message-ID: <55C219C8.8010304@ti.com> (raw)
In-Reply-To: <20150804160631.GH23659-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>

Hi,

On Tuesday 04 August 2015 09:36 PM, Felipe Balbi wrote:
> On Tue, Aug 04, 2015 at 08:50:41PM +0530, Kishon Vijay Abraham I wrote:
>> No functional change. Previously omap_control_phy_power() was used to power
> 
> there is a slight functional change. You moved PHY power off from before
> to after pm_runtime_enable(), clk_prepare_enable() and creation of the
> PHY device. That ought to have a slight impact on how the driver
> behaves.

okay. I'll modify the commit log. I think it won't impact the functionality as
such since the ->init and ->power_on callbacks won't be invoked at that point.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-08-05 14:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04 15:20 [PATCH 0/7] phy: use syscon framework APIs to set ctrl mod reg Kishon Vijay Abraham I
2015-08-04 15:20 ` [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe() Kishon Vijay Abraham I
     [not found]   ` <1438701646-7876-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-08-04 16:00     ` Felipe Balbi
     [not found]       ` <20150804160028.GG23659-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-08-05 14:08         ` Kishon Vijay Abraham I
2015-08-04 15:20 ` [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe Kishon Vijay Abraham I
2015-08-04 16:06   ` Felipe Balbi
     [not found]     ` <20150804160631.GH23659-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-08-05 14:12       ` Kishon Vijay Abraham I [this message]
2015-08-05 15:35         ` Felipe Balbi
2015-08-04 15:20 ` [PATCH 3/7] phy: ti-pipe3: use *syscon* framework API to power on/off the PHY Kishon Vijay Abraham I
     [not found] ` <1438701646-7876-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-08-04 15:20   ` [PATCH 4/7] phy: ti-pipe3: use *syscon* framework API to set PCS value of " Kishon Vijay Abraham I
2015-08-04 15:20 ` [PATCH 5/7] phy: omap-usb2: use omap_usb_power_off to power off the PHY during probe Kishon Vijay Abraham I
2015-08-04 16:07   ` Felipe Balbi
2015-08-04 15:20 ` [PATCH 6/7] phy: omap-usb2: Add a new compatible string for USB2 PHY2 Kishon Vijay Abraham I
     [not found]   ` <1438701646-7876-7-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-08-05  8:23     ` Roger Quadros
2015-08-05  8:25       ` Roger Quadros
2015-08-05 14:18         ` Kishon Vijay Abraham I
2015-08-07  8:27           ` Roger Quadros
2015-08-04 15:20 ` [PATCH 7/7] phy: omap-usb2: use *syscon* framework API to power on/off the PHY Kishon Vijay Abraham I
2015-08-05  8:35   ` Roger Quadros
     [not found]     ` <55C1CAE1.3060901-l0cyMroinI0@public.gmane.org>
2015-08-05 14:21       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C219C8.8010304@ti.com \
    --to=kishon-l0cymroini0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    --cc=rogerq-l0cyMroinI0@public.gmane.org \
    --cc=t-kristo-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).