From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suman Anna Subject: Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle Date: Wed, 5 Aug 2015 10:32:30 -0500 Message-ID: <55C22C8E.3000506@ti.com> References: <1437166592-25378-1-git-send-email-d-gerlach@ti.com> <1437166592-25378-2-git-send-email-d-gerlach@ti.com> <20150805102840.GA16878@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150805102840.GA16878@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren , Dave Gerlach , Jassi Brar Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Santosh Shilimkar , Keerthy List-Id: devicetree@vger.kernel.org Hi Tony, On 08/05/2015 05:28 AM, Tony Lindgren wrote: > * Dave Gerlach [150717 13:59]: >> --- a/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt >> +++ b/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt >> @@ -75,6 +75,14 @@ data that represent the following: >> Cell #3 (usr_id) - mailbox user id for identifying the interrupt line >> associated with generating a tx/rx fifo interrupt. >> >> +Optional Properties: >> +-------------------- >> +- ti,mbox-send-noirq: Quirk flag to allow the client user of this sub-mailbox >> + to send messages without triggering a Tx ready interrupt, >> + and to control the Tx ticker. Should be used only on >> + sub-mailboxes used to communicate with WkupM3 remote >> + processor on AM33xx/AM43xx SoCs. >> + > > Hmm can't you do this just by setting a flag in the device driver > based on the compatible string? We can't because there can be other users like PRUSS which will use a sub-mailbox in a regular fashion. The compatible serves the IP and there can be multiple sub-mailboxes underneath it, and this quirk is needed only on the one that's used by the WkupM3. Jassi, Do you have any comments on this? regards Suman