From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [RFC PATCH v3 0/5] Date: Thu, 6 Aug 2015 08:45:16 +0800 Message-ID: <55C2AE1C.7080502@rock-chips.com> References: <1438762614-22154-1-git-send-email-shawn.lin@rock-chips.com> <55C2A001.2090506@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55C2A001.2090506@samsung.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Krzysztof Kozlowski , Ulf Hansson , Jaehoon Chung , Seungwon Jeon Cc: shawn.lin@rock-chips.com, dianders@chromium.org, linux-mips@linux-mips.org, Arnd Bergmann , Alexandre Belloni , Alexey Brodkin , Stefan Agner , Zhou Wang , Kumar Gala , Alim Akhtar , Ian Campbell , Wang Long , Rob Herring , Chaotian Jing , Lukasz Majewski , Jun Nie , Catalin Marinas , Kevin Hao , Olof Johansson , Ray Jui , Govindraj Raja List-Id: devicetree@vger.kernel.org On 2015/8/6 7:45, Krzysztof Kozlowski wrote: > On 05.08.2015 17:16, Shawn Lin wrote: >> Synopsys DesignWare mobile storage host controller supports three >> types of transfer mode: pio, internal dma and external dma. However, >> dw_mmc can only supports pio and internal dma now. Thus some platforms >> using dw-mshc integrated with generic dma can't work in dma mode. So we >> submit this patch to achieve it. >> >> And the config option, CONFIG_MMC_DW_IDMAC, was added by Will Newton >> (commit:f95f3850) for the first version of dw_mmc and never be touched from >> then. At that time dt-bindings hadn't been introduced into dw_mmc yet means >> we should select CONFIG_MMC_DW_IDMAC to enable internal dma mode at compile >> time. Nowadays, device-tree helps us to support a variety of boards with one >> kernel. That's why we need to remove it and decide the transfer mode at runtime. >> >> This RFC patch needs lots of ACKs. I know it's hard, but it does need someone >> to make the running. >> >> Patch does the following things: >> - remove CONFIG_MMC_DW_IDMAC config option >> - add bindings for idmac and edmac used by synopsys-dw-mshc >> at runtime >> - add edmac support for synopsys-dw-mshc >> >> Patch is based on next of git://git.linaro.org/people/ulf.hansson/mmc >> >> >> Changes in v3: >> - choose transfer mode at runtime >> - remove all CONFIG_MMC_DW_IDMAC config option >> - add supports-idmac property for some platforms >> >> Changes in v2: >> - Fix typo of dev_info msg >> - remove unused dmach from declaration of dw_mci_dma_slave >> >> Shawn Lin (5): >> mmc: dw_mmc: Add external dma interface support >> Documentation: synopsys-dw-mshc: add bindings for idmac and edmac >> arm: configs: remove CONFIG_MMC_DW_IDMAC >> mips: configs: remove CONFIG_MMC_DW_IDMAC >> ARM: dts: add supports-idmac property > Please fix the title of cover letter. > > You CC-ed a lot of people. Probably the whole output of git_maintainers > which is not necessary. This means that your patches did not reach some > of the mailing lists because of too many recipients. I received your > patchset but I can't find it on any of the lists I subscribe. > > Please CC only REAL maintainers, not committers. Right, not the whole output of "cc" by patchman automatically should be involved in the iteration of this patch. I will omit them from this loop in v4. > > Additionally if DTS changes do not have to be introduced atomically > please split it per sub-architecture. Of course that applies only in > case of bisectable patches. And the patchset should preserve > bisectability and backward compatibility (mentioned earlier). okay, it will be split for each sub-architecture. Thanks, Krzysztof. It's helpful. > Best regards, > Krzysztof > > >> .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 41 +++ >> arch/arc/configs/axs101_defconfig | 1 - >> arch/arc/configs/axs103_defconfig | 1 - >> arch/arc/configs/axs103_smp_defconfig | 1 - >> arch/arm/boot/dts/exynos3250-monk.dts | 1 + >> arch/arm/boot/dts/exynos3250-rinato.dts | 1 + >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 + >> arch/arm/boot/dts/exynos4412-origen.dts | 1 + >> arch/arm/boot/dts/exynos4412-trats2.dts | 1 + >> arch/arm/boot/dts/exynos4x12.dtsi | 1 + >> arch/arm/boot/dts/exynos5250-arndale.dts | 2 + >> arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 + >> arch/arm/boot/dts/exynos5250-snow.dts | 3 + >> arch/arm/boot/dts/exynos5250-spring.dts | 2 + >> arch/arm/boot/dts/exynos5260-xyref5260.dts | 2 + >> arch/arm/boot/dts/exynos5410-smdk5410.dts | 2 + >> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 + >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 3 + >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 + >> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 + >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 + >> arch/arm/boot/dts/hisi-x5hd2.dtsi | 2 + >> arch/arm/boot/dts/rk3288-evb.dtsi | 2 + >> arch/arm/boot/dts/rk3288-firefly.dtsi | 3 + >> arch/arm/boot/dts/rk3288-popmetal.dts | 2 + >> arch/arm/configs/exynos_defconfig | 1 - >> arch/arm/configs/hisi_defconfig | 1 - >> arch/arm/configs/lpc18xx_defconfig | 1 - >> arch/arm/configs/multi_v7_defconfig | 1 - >> arch/arm/configs/zx_defconfig | 1 - >> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 + >> arch/mips/configs/pistachio_defconfig | 1 - >> drivers/mmc/host/Kconfig | 11 +- >> drivers/mmc/host/dw_mmc-pltfm.c | 2 + >> drivers/mmc/host/dw_mmc.c | 277 +++++++++++++++++---- >> include/linux/mmc/dw_mmc.h | 28 ++- >> 36 files changed, 338 insertions(+), 72 deletions(-) >> > > > -- Shawn Lin