From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 7/7] ARM: bcm2835: Add VC4 to the device tree.
Date: Fri, 14 Aug 2015 22:54:00 -0600 [thread overview]
Message-ID: <55CEC5E8.6090203@wwwdotorg.org> (raw)
In-Reply-To: <1439427380-2436-8-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
On 08/12/2015 06:56 PM, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
Patch description?
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> arm-pmu {
> compatible = "arm,arm1176-pmu";
> };
> +
> + hdmi: brcm,vc4-hdmi@7e902000 {
It'd be nice to keep all the DT nodes with a reg property together, and
sorted in reg order.
As before, I think any DT node for a HW block that may-or-may-not-be
used based on board connectivity/features should be disabled in the SoC
.dtsi file, and enabled in the board's DT file if the feature is useful
for that board.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-08-15 4:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 0:56 Raspberry Pi KMS-only driver Eric Anholt
2015-08-13 0:56 ` [PATCH 1/7] drm/vc4: Add devicetree bindings for VC4 Eric Anholt
2015-08-15 4:38 ` Stephen Warren
2015-08-17 18:30 ` Eric Anholt
[not found] ` <874mjxwyx5.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2015-08-24 13:47 ` Rob Herring
2015-08-25 20:42 ` Rob Clark
2015-08-25 23:22 ` Rob Herring
2015-08-26 11:52 ` Daniel Vetter
2015-08-26 12:09 ` Thierry Reding
[not found] ` <20150826120934.GC320-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2015-08-26 14:30 ` Rob Herring
2015-08-26 20:59 ` Dave Airlie
[not found] ` <CAPM=9tw=3yGQE3_G+=ian-+iV-OCRatbFc-stoMczmXeM2Ko+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-27 0:35 ` Rob Herring
2015-08-26 11:51 ` Thierry Reding
2015-08-24 13:56 ` Rob Herring
2015-08-13 0:56 ` [PATCH 2/7] MAINTAINERS: Add myself for the new VC4 (RPi GPU) graphics driver Eric Anholt
[not found] ` <1439427380-2436-3-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
2015-08-15 4:39 ` Stephen Warren
[not found] ` <55CEC29C.806-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-08-17 18:47 ` Eric Anholt
2015-08-13 0:56 ` [PATCH 3/7] drm/vc4: Add KMS support for Raspberry Pi Eric Anholt
2015-08-13 7:51 ` Daniel Vetter
2015-08-13 20:44 ` Eric Anholt
2015-08-13 21:17 ` Daniel Vetter
2015-08-18 20:56 ` Eric Anholt
2015-08-13 21:29 ` Russell King - ARM Linux
2015-08-13 23:03 ` Eric Anholt
[not found] ` <1439427380-2436-4-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
2015-08-13 11:45 ` Emil Velikov
2015-08-15 4:45 ` Stephen Warren
2015-08-17 17:56 ` Eric Anholt
2015-08-13 0:56 ` [PATCH 4/7] drm/vc4: Use the fbdev_cma helpers Eric Anholt
2015-08-13 0:56 ` [PATCH 5/7] drm/vc4: Allow vblank to be disabled Eric Anholt
2015-08-13 0:56 ` [PATCH 6/7] ARM: bcm2835: Add the DDC I2C controller to the device tree Eric Anholt
[not found] ` <1439427380-2436-7-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
2015-08-15 4:51 ` Stephen Warren
2015-08-17 18:35 ` Eric Anholt
2015-08-13 0:56 ` [PATCH 7/7] ARM: bcm2835: Add VC4 " Eric Anholt
[not found] ` <1439427380-2436-8-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
2015-08-15 4:54 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CEC5E8.6090203@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \
--cc=lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).