From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 7/7] ARM: bcm2835: Add VC4 to the device tree. Date: Fri, 14 Aug 2015 22:54:00 -0600 Message-ID: <55CEC5E8.6090203@wwwdotorg.org> References: <1439427380-2436-1-git-send-email-eric@anholt.net> <1439427380-2436-8-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1439427380-2436-8-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Anholt Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lee Jones , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 08/12/2015 06:56 PM, Eric Anholt wrote: > Signed-off-by: Eric Anholt Patch description? > diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi > arm-pmu { > compatible = "arm,arm1176-pmu"; > }; > + > + hdmi: brcm,vc4-hdmi@7e902000 { It'd be nice to keep all the DT nodes with a reg property together, and sorted in reg order. As before, I think any DT node for a HW block that may-or-may-not-be used based on board connectivity/features should be disabled in the SoC .dtsi file, and enabled in the board's DT file if the feature is useful for that board. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html