Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2133 bytes --]



On 17/08/15 19:48, Andrew Lunn wrote:
>> TLC591xx is quite simple HW, and the code doing the HW programming
>> should be identical for a pwm and for a led driver. I don't see either a
>> pwm or a led driver being somehow superior. They are very similar simple
>> drivers, implementing a different interface. Whether the interface works
>> for you should be clear from the interface itself. The code is just details.
>>
>> On the other hand, if you want something you can use to test, it's a
>> different case, but you haven't indicated any interest in that.
> 
> What i want is code in the kernel to driver the LEDs on my Linksys
> WRT1900ac. You say, "the code is just details", is just plain
> wrong. Code is the Linux kernel and is the process of getting stuff
> into the kernel. I've followed the process, submitted code for review,
> fixed up comments, got it tested and ACKed by people, and merged.

Your process also included in ignoring my questions, and dropping me
from cc so you'd get the driver merged. My idea of the Linux development
process differs greatly from yours.

> Where as all you have done is emailed.

Yes, as you were writing the driver for the HW, and I was expecting
answers from you. I would find it rather rude if I'm working on a
driver, getting comments on it and fixing things, and suddenly someone
else goes and writes his own version of the driver for the HW.

I presumed that you would either answer to my comments, or you would cc
me when you want to ping the maintainers.

Sure, if the driver is complex or somehow controversial it's good to
have different implementations of the driver so the best one can be
picked. This is not the case here. The HW is simple, and both PWM and
LED interfaces are simple. The code is just details in such a case.

I can post a pwm based driver tomorrow. I could've done that long ago if
you would have just said that you're not interested in finding answers
to my questions or trying a pwm driver. Or if you'd have bothered to cc
me in the last series, so I would've realized you are done with the driver.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]