* [PATCH] arm64: dts: Add BUS1 instance pinctrl support
@ 2015-08-28 11:25 Alim Akhtar
2015-08-31 5:42 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Alim Akhtar @ 2015-08-28 11:25 UTC (permalink / raw)
To: devicetree, linux-arm-kernel, linux-samsung-soc
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
catalin.marinas, will.deacon, kgene, k.kozlowski, gautam.vivek
This adds BUS1 instance pinctrl for exynos7 soc.
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 111 +++++++++++++++++++++++
arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 ++
2 files changed, 118 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
index 2eef4a2..96be6e3 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
@@ -586,3 +586,114 @@
samsung,pin-drv = <2>;
};
};
+
+&pinctrl_bus1 {
+ etc1: etc1 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpf0: gpf0 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpf1: gpf1 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpf2: gpf2 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpf3: gpf3 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpf4: gpf4 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpf5: gpf5 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpg1: gpg1 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpg2: gpg2 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gph1: gph1 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpv6: gpv6 {
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ spi5_bus: spi5-bus {
+ samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <3>;
+ samsung,pin-drv = <0>;
+ };
+
+ ufs_refclk_out: ufs-refclk-out {
+ samsung,pins = "gpg2-4";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <2>;
+ };
+
+ ufs_rst_n: ufs-rst-n {
+ samsung,pins = "gph1-5";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <3>;
+ samsung,pin-drv = <0>;
+ };
+};
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index d7a37c3..f9c5a54 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -26,6 +26,7 @@
pinctrl5 = &pinctrl_ese;
pinctrl6 = &pinctrl_fsys0;
pinctrl7 = &pinctrl_fsys1;
+ pinctrl8 = &pinctrl_bus1;
};
cpus {
@@ -278,6 +279,12 @@
interrupts = <0 203 0>;
};
+ pinctrl_bus1: pinctrl@14870000 {
+ compatible = "samsung,exynos7-pinctrl";
+ reg = <0x14870000 0x1000>;
+ interrupts = <0 384 0>;
+ };
+
hsi2c_0: hsi2c@13640000 {
compatible = "samsung,exynos7-hsi2c";
reg = <0x13640000 0x1000>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: Add BUS1 instance pinctrl support
2015-08-28 11:25 [PATCH] arm64: dts: Add BUS1 instance pinctrl support Alim Akhtar
@ 2015-08-31 5:42 ` Krzysztof Kozlowski
2015-09-14 5:08 ` Alim Akhtar
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-08-31 5:42 UTC (permalink / raw)
To: Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
catalin.marinas, will.deacon, kgene, gautam.vivek
On 28.08.2015 20:25, Alim Akhtar wrote:
> This adds BUS1 instance pinctrl for exynos7 soc.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 111 +++++++++++++++++++++++
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 ++
> 2 files changed, 118 insertions(+)
The "etc1" GPIO in my datasheet is not fully documented but the rest
looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: Add BUS1 instance pinctrl support
2015-08-31 5:42 ` Krzysztof Kozlowski
@ 2015-09-14 5:08 ` Alim Akhtar
2015-09-14 5:51 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Alim Akhtar @ 2015-09-14 5:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
catalin.marinas, will.deacon, kgene, gautam.vivek
Hi
On 08/31/2015 11:12 AM, Krzysztof Kozlowski wrote:
> On 28.08.2015 20:25, Alim Akhtar wrote:
>> This adds BUS1 instance pinctrl for exynos7 soc.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 111 +++++++++++++++++++++++
>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 ++
>> 2 files changed, 118 insertions(+)
>
> The "etc1" GPIO in my datasheet is not fully documented but the rest
> looks good:
>
Ok will send v2 and remove etc1 gpio node.
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
Thanks!!
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: Add BUS1 instance pinctrl support
2015-09-14 5:08 ` Alim Akhtar
@ 2015-09-14 5:51 ` Krzysztof Kozlowski
2015-09-14 6:16 ` Alim Akhtar
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-09-14 5:51 UTC (permalink / raw)
To: Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
catalin.marinas, will.deacon, kgene, gautam.vivek
On 14.09.2015 14:08, Alim Akhtar wrote:
> Hi
>
> On 08/31/2015 11:12 AM, Krzysztof Kozlowski wrote:
>> On 28.08.2015 20:25, Alim Akhtar wrote:
>>> This adds BUS1 instance pinctrl for exynos7 soc.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> ---
>>> arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 111
>>> +++++++++++++++++++++++
>>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 ++
>>> 2 files changed, 118 insertions(+)
>>
>> The "etc1" GPIO in my datasheet is not fully documented but the rest
>> looks good:
>>
> Ok will send v2 and remove etc1 gpio node.
You don't have to. I mentioned it only for reference that I cannot
review the etc GPIO node because it is not mentioned in my datasheet.
However you may have different (e.g. newer) datasheet and etc1 could be
documented there.
I applied the first version of patch some time ago (your response is
after two weeks). Do you want me to replace it with v2?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: Add BUS1 instance pinctrl support
2015-09-14 5:51 ` Krzysztof Kozlowski
@ 2015-09-14 6:16 ` Alim Akhtar
2015-09-14 6:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Alim Akhtar @ 2015-09-14 6:16 UTC (permalink / raw)
To: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
catalin.marinas, will.deacon, kgene, gautam.vivek
Hello,
On 09/14/2015 11:21 AM, Krzysztof Kozlowski wrote:
> On 14.09.2015 14:08, Alim Akhtar wrote:
>> Hi
>>
>> On 08/31/2015 11:12 AM, Krzysztof Kozlowski wrote:
>>> On 28.08.2015 20:25, Alim Akhtar wrote:
>>>> This adds BUS1 instance pinctrl for exynos7 soc.
>>>>
>>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>>> ---
>>>> arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 111
>>>> +++++++++++++++++++++++
>>>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 ++
>>>> 2 files changed, 118 insertions(+)
>>>
>>> The "etc1" GPIO in my datasheet is not fully documented but the rest
>>> looks good:
>>>
>> Ok will send v2 and remove etc1 gpio node.
>
> You don't have to. I mentioned it only for reference that I cannot
> review the etc GPIO node because it is not mentioned in my datasheet.
> However you may have different (e.g. newer) datasheet and etc1 could be
> documented there.
>
Sorry for delay, I check two versions of the UM and unfortunately both
show incomplete entries for etc1, my downstream code has these changes
though.
> I applied the first version of patch some time ago (your response is
> after two weeks). Do you want me to replace it with v2?
>
Please consider taking my v2 which I just posted.
Thanks again.
> Best regards,
> Krzysztof
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: Add BUS1 instance pinctrl support
2015-09-14 6:16 ` Alim Akhtar
@ 2015-09-14 6:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-09-14 6:26 UTC (permalink / raw)
To: Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
catalin.marinas, will.deacon, kgene, gautam.vivek
On 14.09.2015 15:16, Alim Akhtar wrote:
> Hello,
>
> On 09/14/2015 11:21 AM, Krzysztof Kozlowski wrote:
>> On 14.09.2015 14:08, Alim Akhtar wrote:
>>> Hi
>>>
>>> On 08/31/2015 11:12 AM, Krzysztof Kozlowski wrote:
>>>> On 28.08.2015 20:25, Alim Akhtar wrote:
>>>>> This adds BUS1 instance pinctrl for exynos7 soc.
>>>>>
>>>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>>>> ---
>>>>> arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 111
>>>>> +++++++++++++++++++++++
>>>>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 ++
>>>>> 2 files changed, 118 insertions(+)
>>>>
>>>> The "etc1" GPIO in my datasheet is not fully documented but the rest
>>>> looks good:
>>>>
>>> Ok will send v2 and remove etc1 gpio node.
>>
>> You don't have to. I mentioned it only for reference that I cannot
>> review the etc GPIO node because it is not mentioned in my datasheet.
>> However you may have different (e.g. newer) datasheet and etc1 could be
>> documented there.
>>
> Sorry for delay, I check two versions of the UM and unfortunately both
> show incomplete entries for etc1, my downstream code has these changes
> though.
>> I applied the first version of patch some time ago (your response is
>> after two weeks). Do you want me to replace it with v2?
>>
> Please consider taking my v2 which I just posted.
> Thanks again.
Okay, I'll replace the patch with v2.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-14 6:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-28 11:25 [PATCH] arm64: dts: Add BUS1 instance pinctrl support Alim Akhtar
2015-08-31 5:42 ` Krzysztof Kozlowski
2015-09-14 5:08 ` Alim Akhtar
2015-09-14 5:51 ` Krzysztof Kozlowski
2015-09-14 6:16 ` Alim Akhtar
2015-09-14 6:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).