From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
agross@codeaurora.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/6] ARM: dts: apq8064-ifc6410: add notify led support.
Date: Thu, 03 Sep 2015 16:49:03 +0100 [thread overview]
Message-ID: <55E86BEF.3010403@linaro.org> (raw)
In-Reply-To: <55DCDFC1.4010803@codeaurora.org>
On 25/08/15 22:36, Stephen Boyd wrote:
> On 08/18/2015 06:10 AM, Srinivas Kandagatla wrote:
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> index b1f9ddb..08daafe 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> @@ -221,6 +221,18 @@
>> status = "okay";
>> };
>> + leds {
>> + compatible = "gpio-leds";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <¬ify_led>;
>> +
>> + led@1 {
>> + label = "apq8064:green:user1";
>> + gpios = <&pm8921_gpio 18 GPIO_ACTIVE_HIGH>;
>> + default-state = "on";
>> + };
>> + };
>
> Wrong place. Should be in root, not soc node.
yep, Will move it to the root.
>
next prev parent reply other threads:[~2015-09-03 15:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 13:04 [PATCH v2 0/6] DT: APQ8064 for qcom-dt-next Srinivas Kandagatla
2015-08-18 13:06 ` [PATCH v2 1/6] ARM: dts: ifc6410: Add pwrseq support for WLAN Srinivas Kandagatla
[not found] ` <1439903212-19931-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-08-25 21:33 ` Stephen Boyd
2015-09-03 15:45 ` Srinivas Kandagatla
[not found] ` <1439903069-19752-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-08-18 13:10 ` [PATCH v2 2/6] ARM: dts: qs600: add pwrseq support to WLAN Srinivas Kandagatla
2015-08-18 13:10 ` [PATCH v2 3/6] ARM: dts: apq8064-ifc6410: add notify led support Srinivas Kandagatla
2015-08-25 21:36 ` Stephen Boyd
2015-09-03 15:49 ` Srinivas Kandagatla [this message]
2015-08-18 13:10 ` [PATCH v2 4/6] ARM: dts: qs600: remove unnecessary i2c pinctrl nodes in board file Srinivas Kandagatla
2015-08-25 21:24 ` Andy Gross
2015-08-18 13:10 ` [PATCH v2 5/6] ARM: dts: qs600: add alias to serial0 Srinivas Kandagatla
2015-08-25 21:39 ` Stephen Boyd
2015-08-25 21:46 ` Andy Gross
2015-08-27 4:53 ` Andy Gross
2015-08-18 13:10 ` [PATCH v2 6/6] ARM: dts: qs600: Add SD card detect support Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E86BEF.3010403@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).