From: "Janusz Użycki" <j.uzycki-cjVIcFy54eMe9JSWTWOYM+658FiBabzs@public.gmane.org>
To: Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Krzysztof Borgulski
<k.borgulski-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
Subject: Re: [RFC] gpio-pca953x driver and PCA9536 chip
Date: Fri, 4 Sep 2015 11:33:26 +0200 [thread overview]
Message-ID: <55E96566.7000502@elpromaelectronics.com> (raw)
In-Reply-To: <55E4641D.7050603-cjVIcFy54eMe9JSWTWOYM+658FiBabzs@public.gmane.org>
W dniu 2015-08-31 o 16:26, Janusz Użycki pisze:
> Hi,
>
> The driver sets register #02 (inversion) to 0x01 instead of 0x00 on my
> board.
> Reason: device_pca953x_init() does not initialize val buffer because
> NBANK() returns
> for PCA9536 ngpio=4 value 0 instead of 1.
>
> My proposed code-patch for 3.14.17 is below.
> Because I don't work on stable/next I can't deliver complete/ready patch.
> Please for comments.
>
> best regards
> Janusz
>
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -75,7 +75,7 @@ MODULE_DEVICE_TABLE(i2c, pca953x_id);
> #define MAX_BANK 5
> #define BANK_SZ 8
>
> -#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ)
> +#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ)
>
> struct pca953x_chip {
> unsigned gpio_start;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-04 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 14:26 [RFC PATCH] gpio-pca953x driver and PCA9536 chip Janusz Użycki
[not found] ` <55E4641D.7050603-cjVIcFy54eMe9JSWTWOYM+658FiBabzs@public.gmane.org>
2015-09-04 9:33 ` Janusz Użycki [this message]
2015-09-05 21:15 ` Linus Walleij
2015-09-07 12:36 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E96566.7000502@elpromaelectronics.com \
--to=j.uzycki-cjvicfy54eme9jswtwoym+658fibabzs@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=k.borgulski-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).