From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Janusz_U=c5=bcycki?= Subject: Re: [RFC] gpio-pca953x driver and PCA9536 chip Date: Fri, 4 Sep 2015 11:33:26 +0200 Message-ID: <55E96566.7000502@elpromaelectronics.com> References: <55E4641D.7050603@elpromaelectronics.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <55E4641D.7050603-cjVIcFy54eMe9JSWTWOYM+658FiBabzs@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij Cc: Krzysztof Borgulski List-Id: devicetree@vger.kernel.org W dniu 2015-08-31 o 16:26, Janusz U=C5=BCycki pisze: > Hi, > > The driver sets register #02 (inversion) to 0x01 instead of 0x00 on m= y=20 > board. > Reason: device_pca953x_init() does not initialize val buffer because=20 > NBANK() returns > for PCA9536 ngpio=3D4 value 0 instead of 1. > > My proposed code-patch for 3.14.17 is below. > Because I don't work on stable/next I can't deliver complete/ready pa= tch. > Please for comments. > > best regards > Janusz > > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -75,7 +75,7 @@ MODULE_DEVICE_TABLE(i2c, pca953x_id); > #define MAX_BANK 5 > #define BANK_SZ 8 > > -#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ) > +#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ) > > struct pca953x_chip { > unsigned gpio_start; -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html