From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathias Nyman Subject: Re: [PATCH v7 4/5] xhci: mediatek: support MTK xHCI host controller Date: Tue, 08 Sep 2015 13:45:07 +0300 Message-ID: <55EEBC33.5030906@intel.com> References: <1441693083-8440-1-git-send-email-chunfeng.yun@mediatek.com> <1441693083-8440-5-git-send-email-chunfeng.yun@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441693083-8440-5-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chunfeng Yun Cc: Rob Herring , Mark Rutland , Matthias Brugger , Felipe Balbi , Sascha Hauer , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Roger Quadros , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, John Crispin , Daniel Kurtz , Sergei Shtylyov , Kishon Vijay Abraham I , Pawel Moll , Ian Campbell , Kumar Gala , Greg Kroah-Hartman List-Id: devicetree@vger.kernel.org Hi On 08.09.2015 09:18, Chunfeng Yun wrote: > There some vendor quirks for MTK xhci host controller: > 1. It defines some extra SW scheduling parameters for HW > to minimize the scheduling effort for synchronous and > interrupt endpoints. The parameters are put into reseved > DWs of slot context and endpoint context. > 2. Its IMODI unit for Interrupter Moderation register is > 8 times as much as that defined in xHCI spec. > 3. Its TDS in Normal TRB defines a number of packets that > remains to be transferred for a TD after processing all > Max packets in all previous TRBs. > I just rewrote and unified the the xhci TD remainder functions, now we got only one xhci_td_remainder() function which should be more suitable for quirks. You can add the quirk directly to it, no need to duplicate the whole function. -Mathias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html