From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Date: Tue, 8 Sep 2015 18:46:14 -0500 Message-ID: <55EF7346.5040607@kernel.org> References: <1441705796-11365-1-git-send-email-bayi.cheng@mediatek.com> <1441705796-11365-4-git-send-email-bayi.cheng@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ezequiel Garcia , Jagan Teki Cc: Bayi Cheng , Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Pawel Moll , Ian Campbell , Sascha Hauer , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Daniel Kurtz , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kumar Gala , Matthias Brugger , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Brian Norris , David Woodhouse , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On 09/08/2015 10:18 AM, Ezequiel Garcia wrote: > On 8 September 2015 at 08:53, Jagan Teki wrote: >> On 8 September 2015 at 15:19, Bayi Cheng wrote: >>> Add Mediatek nor flash node >>> >>> Signed-off-by: Bayi Cheng >>> --- >>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> index d18ee42..a14f005 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> @@ -365,6 +365,16 @@ >>> status = "disabled"; >>> }; >>> >>> + nor_flash: nor@1100d000 { >> >> Based on the comments from 1/3 - this notation needs to be change something like >> qspi0: quadspi@1100d000 >> > > Actually, to follow ePAPR recomendations it should be named as flash@1100d000. > (See ePAPR, 2.2.2 Generic Names Recommendation). The flash device node should, but this is the controller which should be "spi" IMO even if this is not a general purpose controller. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html