From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger Date: Thu, 10 Sep 2015 08:47:46 +0900 Message-ID: <55F0C522.6070705@samsung.com> References: <1441560187-23611-1-git-send-email-ramakrishna.pallala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-pm-owner@vger.kernel.org To: "Pallala, Ramakrishna" Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , Sebastian Reichel , "Tc, Jenny" , Andreas Dannenberg List-Id: devicetree@vger.kernel.org On 10.09.2015 03:11, Pallala, Ramakrishna wrote: >>> +Optional properties: >>> +- ti,thermal-sensing: boolean, if present thermal regulation will be >>> +enabled; >> >> What is the requirement for thermal-sensing? Can it be enabled always? >> If yes, then this is not really a hardware property. > TI BQ24261 has provision to add Battery Pack thermistor but it has no ADC read it. > So a HW designer would or may not add the thermistor to charger and instead he can > connect to the Fuel Gauge. Thanks for explanation, makes sense. > >>> +- ti,enable-user-write: boolean, if present driver will allow the user space >>> + to control the charging current and voltage through sysfs; >> >> This is not DT property. It does not describe hardware. > We needed a mechanism to enable the sysfs writes on certain properties. > If DT is not the place where should it go? DT is not the place. As I discussed later with Andreas, if you really need this and if mainline is a place for that then probably this should be compile option (a Kconfig symbol). I found one more issue after Andreas comments but I respond in that email. Best regards, Krzysztof