From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
lee.jones@linaro.org
Cc: myungjoo.ham@samsung.com, sameo@linux.intel.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 6/6] mfd: arizona: Update DT binding documentation for jack detection
Date: Fri, 11 Sep 2015 17:09:04 +0900 [thread overview]
Message-ID: <55F28C20.2080800@samsung.com> (raw)
In-Reply-To: <1441885307-24499-6-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On 2015년 09월 10일 20:41, Charles Keepax wrote:
> Add additional bindings for both inverting the polarity of the jack
> detection pins and allowing the use of a second jack detection pin. Note
> that the second jack detection pin is hard wired in the chip so can only
> be enabled through the binding, rather than a pin being specified.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index b98a11b..48bca6a 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -73,6 +73,12 @@ Optional properties:
> If this node is not mentioned or if the value is unknown, then
> headphone detection mode is set to HPDETL.
>
> + - wlf,use-jd-gpio : Use GPIO input alongwith JD1 for dual pin jack
s/alongwith/along with
> + detection.
> + - wlf,use-jd-gpio-nopull : Internal pull on GPIO is disabled when used for
> + jack detection.
> + - wlf,jd-invert : Invert the polarity of the jack detection switch
> +
> - wlf,micd-software-compare : Use a software comparison to determine mic
> presence
> - wlf,micd-detect-debounce : Additional software microphone detection
>
If you fixes the minor typo, looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2015-09-11 8:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 11:41 [PATCH 1/6] mfd: arizona: Add TST_CAP bits for headphone detection Charles Keepax
[not found] ` <1441885307-24499-1-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-09-10 11:41 ` [PATCH 2/6] extcon: arizona: Additional settings to improve accuracy of HP detect Charles Keepax
2015-09-11 8:16 ` Chanwoo Choi
2015-09-10 11:41 ` [PATCH 3/6] extcon: arizona: Ignore jd_invert for MICD_CLAMP_STS Charles Keepax
[not found] ` <1441885307-24499-3-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-09-11 8:05 ` Chanwoo Choi
2015-09-10 11:41 ` [PATCH 4/6] extcon: arizona: Add device binding for jack detect polarity inversion Charles Keepax
[not found] ` <1441885307-24499-4-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-09-11 8:07 ` Chanwoo Choi
2015-09-10 11:41 ` [PATCH 5/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5 Charles Keepax
2015-09-11 8:07 ` Chanwoo Choi
2015-09-10 11:41 ` [PATCH 6/6] mfd: arizona: Update DT binding documentation for jack detection Charles Keepax
2015-09-11 8:09 ` Chanwoo Choi [this message]
2015-09-11 8:12 ` [PATCH 1/6] mfd: arizona: Add TST_CAP bits for headphone detection Chanwoo Choi
-- strict thread matches above, loose matches on Subject: below --
2015-09-16 9:56 [PATCH 0/6] Arizona Extcon Update Device Bindings Charles Keepax
[not found] ` <1442397404-7579-1-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-09-16 9:56 ` [PATCH 6/6] mfd: arizona: Update DT binding documentation for jack detection Charles Keepax
2015-09-20 4:17 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F28C20.2080800@samsung.com \
--to=cw00.choi@samsung.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).