devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Florian Fainelli
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 1/3] Documentation: bindings: brcmstb: Document write-pairing
Date: Mon, 14 Sep 2015 15:36:41 -0500	[thread overview]
Message-ID: <55F72FD9.60607@kernel.org> (raw)
In-Reply-To: <1442260369-6575-2-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 09/14/2015 02:52 PM, Florian Fainelli wrote:
> Document the hif-cpubiuctrl node a bit more, and add a documentation
> entry for the optional "brcm,write-pairing" property.
> 
> Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  .../devicetree/bindings/arm/bcm/brcm,brcmstb.txt          | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt
> index 430608ec09f0..602fa5f308bb 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt
> @@ -20,6 +20,20 @@ system control is required:
>      - compatible: "brcm,bcm<chip_id>-hif-cpubiuctrl", "syscon"

This has multiple chips allowed, but...

>      - compatible: "brcm,bcm<chip_id>-hif-continuation", "syscon"
>  
> +hif-cpubiuctrl node
> +-------------------

Perhaps it is outside this context, but a description of the block would
be nice.

> +
> +Required properties:
> +
> +    - compatible
> +	The string should be "brcm.bcm7445-hif-cpubiuctrl", "syscon"

This is just one.

> +
> +Optional properties:
> +
> +    - brcm,write-pairing:
> +	Boolean property, which when present indicatse that the chip

s/indicatse/indicates/

> +	supports write-pairing.

What is write pairing? Please give brief description.

> +
>  example:
>      rdb {
>          #address-cells = <1>;
> @@ -35,6 +49,7 @@ example:
>          hif_cpubiuctrl: syscon@3e2400 {
>              compatible = "brcm,bcm7445-hif-cpubiuctrl", "syscon";
>              reg = <0x3e2400 0x5b4>;
> +            brcm,write-pairing;
>          };
>  
>          hif_continuation: syscon@452000 {
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-09-14 20:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 19:52 [PATCH 0/3] ARM: brcmstb: Bus Interface Unit support Florian Fainelli
     [not found] ` <1442260369-6575-1-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-14 19:52   ` [PATCH 1/3] Documentation: bindings: brcmstb: Document write-pairing Florian Fainelli
     [not found]     ` <1442260369-6575-2-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-14 20:36       ` Rob Herring [this message]
     [not found]         ` <55F72FD9.60607-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-14 21:21           ` Florian Fainelli
2015-09-14 19:52   ` [PATCH 2/3] soc: brcmstb: Add Bus Interface Unit control setup Florian Fainelli
2015-09-14 19:52   ` [PATCH 3/3] ARM: brcmstb: Setup BIU control registers during boot Florian Fainelli
     [not found]     ` <1442260369-6575-4-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-14 20:48       ` Brian Norris
     [not found]         ` <20150914204833.GA53555-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-09-14 21:21           ` Florian Fainelli
     [not found]             ` <55F73A47.9070900-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-14 21:29               ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F72FD9.60607@kernel.org \
    --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).