From: Rob Herring <robh@kernel.org>
To: Xinwei Kong <kong.kongxinwei@hisilicon.com>,
airlied@linux.ie, corbet@lwn.net, catalin.marinas@arm.com,
will.deacon@arm.com
Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
xinliang.liu@linaro.org, andy.green@linaro.org,
qijiwen@hisilicon.com, gongyu@hisilicon.com,
haojian.zhuang@linaro.org, liguozhu@hisilicon.com,
xuwei5@hisilicon.com, yinshengbao@hisilicon.com,
yanhaifeng@hisilicon.com, ml.yang@hisilicon.com,
yimin@huawei.com, w.f@huawei.com, puck.chen@hisilicon.com,
bintian.wang@huawei.com, benjamin.gaignard@linaro.org,
xuyiping@hisilicon.com, james.yanglong@hisilicon.com,
fangdechun@hisilicon.com
Subject: Re: [PATCH RFC 6/8] drm: hisilicon: Add support for fbdev
Date: Tue, 15 Sep 2015 13:25:37 -0500 [thread overview]
Message-ID: <55F862A1.30308@kernel.org> (raw)
In-Reply-To: <1442309834-21420-7-git-send-email-kong.kongxinwei@hisilicon.com>
On 09/15/2015 04:37 AM, Xinwei Kong wrote:
> If you config DRM_HISI_FBDEV optional, this patch will only support fbdev
> mode while also supporting double buffer.
This is a lot of duplicated code from CMA fbdev. Is double buffering the
only reason why CMA fbdev can't be used or are there some other
constraints? Double buffering in fbdev has always been a hack, so I'm
guessing that is not a feature that should be added here.
Rob
> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Signed-off-by: Andy Green <andy.green@linaro.org>
> Signed-off-by: Jiwen Qi <qijiwen@hisilicon.com>
> Signed-off-by: Yu Gong <gongyu@hisilicon.com>
> ---
> drivers/gpu/drm/hisilicon/Kconfig | 13 +
> drivers/gpu/drm/hisilicon/Makefile | 3 +-
> drivers/gpu/drm/hisilicon/hisi_drm_connector.c | 4 +
> drivers/gpu/drm/hisilicon/hisi_drm_drv.c | 9 +
> drivers/gpu/drm/hisilicon/hisi_drm_dsi.c | 15 +
> drivers/gpu/drm/hisilicon/hisi_drm_fb.h | 5 +
> drivers/gpu/drm/hisilicon/hisi_drm_fbdev.c | 395 +++++++++++++++++++++++++
> drivers/gpu/drm/hisilicon/hisi_drm_fbdev.h | 24 ++
> 8 files changed, 467 insertions(+), 1 deletion(-)
> create mode 100644 drivers/gpu/drm/hisilicon/hisi_drm_fbdev.c
> create mode 100644 drivers/gpu/drm/hisilicon/hisi_drm_fbdev.h
next prev parent reply other threads:[~2015-09-15 18:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 9:37 [PATCH RFC 0/8] Add New DRM Driver for Hisilicon's Hi6220 SoC Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 1/8] dt-bindings: Document the hi6220 bindings for DRM driver Xinwei Kong
2015-09-15 18:11 ` Rob Herring
2015-09-16 8:34 ` Xinwei Kong
2015-09-16 9:10 ` Archit Taneja
2015-09-17 12:14 ` Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 2/8] drm: hisilicon: Add new DRM driver for hisilicon Soc Xinwei Kong
2015-09-17 11:13 ` Archit Taneja
2015-09-15 9:37 ` [PATCH RFC 3/8] drm: hisilicon: Add the link to DRM/KMS interface Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 4/8] drm: hisilicon: fill interface function of plane\crtc part Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 5/8] drm: hisilicon: fill interface function of encoder\connector part Xinwei Kong
2015-09-17 11:39 ` Archit Taneja
2015-09-15 9:37 ` [PATCH RFC 6/8] drm: hisilicon: Add support for fbdev Xinwei Kong
2015-09-15 18:25 ` Rob Herring [this message]
2015-09-16 3:32 ` Xinwei Kong
2015-09-16 9:48 ` Xinliang Liu
2015-09-17 11:52 ` Rob Clark
2015-09-17 12:11 ` Xinliang Liu
2015-09-15 9:37 ` [PATCH RFC 7/8] drm: hisilicon: Add support for vblank Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 8/8] dts: hisilicon: Add drm driver device dts config for HiKey board Xinwei Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F862A1.30308@kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=andy.green@linaro.org \
--cc=benjamin.gaignard@linaro.org \
--cc=bintian.wang@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fangdechun@hisilicon.com \
--cc=gongyu@hisilicon.com \
--cc=haojian.zhuang@linaro.org \
--cc=james.yanglong@hisilicon.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=ml.yang@hisilicon.com \
--cc=puck.chen@hisilicon.com \
--cc=qijiwen@hisilicon.com \
--cc=w.f@huawei.com \
--cc=will.deacon@arm.com \
--cc=xinliang.liu@linaro.org \
--cc=xuwei5@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yanhaifeng@hisilicon.com \
--cc=yimin@huawei.com \
--cc=yinshengbao@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).