From: Kukjin Kim <kgene@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski.k@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3
Date: Thu, 17 Sep 2015 07:52:47 +0900 [thread overview]
Message-ID: <55F9F2BF.2060904@kernel.org> (raw)
In-Reply-To: <55F8AFAC.5090305@samsung.com>
On 09/16/15 08:54, Krzysztof Kozlowski wrote:
> On 16.09.2015 08:35, Kukjin Kim wrote:
>> On 09/13/15 18:32, Krzysztof Kozlowski wrote:
>>> The LEDs on Odroid XU3 family boards could not properly probe because PWM
>>> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
>>> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
>>> for MIPI probably is redundant because board does not have MIPI
>>> connector available).
>>>
>>> This fixes warnings on dmesg:
>>> [ 4.838712] samsung-pwm 12dd0000.pwm: tried to request PWM channel 1 without output
>>> [ 4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
>>> [ 4.838767] leds_pwm: probe of pwmleds failed with error -22
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>>>
>>> ---
>>>
>>> Changes since v1:
>>> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>>> just on current next.
>>> ---
>>
>> Applied, thanks.
>>
>
> Thanks. This is actually a candidate for current v4.3 cycle. It fixes
> issue with LEDs for Odroid XU3 caused by Anand's b685d540cc26:
> The offending commit b685d540cc26 was merged in v4.3.
> I forgot to add "fixes" tag.
> Fixes: b685d540cc26 ("ARM: dts: Add pwm-fan node for exynos5422-odroidxu3")
>
> Can you send it to arm-soc during this cycle?
>
Why not? Will do it ;-)
> For current v4.3 Bartlomiej's patch is also an important candidate:
> "ARM: dts: add suspend opp to exynos4412"
>
Thanks for gentle reminder.
- Kukjin
prev parent reply other threads:[~2015-09-16 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 9:32 [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3 Krzysztof Kozlowski
2015-09-15 23:35 ` Kukjin Kim
2015-09-15 23:54 ` Krzysztof Kozlowski
2015-09-16 22:52 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F9F2BF.2060904@kernel.org \
--to=kgene@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski.k@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).