From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Wu Subject: Re: [PATCH] ARM: at91/dt: ov2640: add hsync/vsync-active property Date: Mon, 21 Sep 2015 09:19:48 +0800 Message-ID: <55FF5B34.8040500@atmel.com> References: <1442575702-22315-1-git-send-email-josh.wu@atmel.com> <55FC1B12.8000703@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <55FC1B12.8000703-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicolas Ferre Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Russell King , Kumar Gala , Jean-Christophe Plagniol-Villard , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ian Campbell , Alexandre Belloni , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland List-Id: devicetree@vger.kernel.org Hi, Nicolas On 9/18/2015 10:09 PM, Nicolas Ferre wrote: > Le 18/09/2015 13:28, Josh Wu a =E9crit : >> On at91sam9x5ek/at91sam9m10g45ek/sama5d3xek boards, we use the paral= lel >> connection for ov2640. So we must set the hsync/vsync property (1 me= ans >> active high). >> Otherwise, the connection would be seen as BT.656 or BT.1120. >> >> Signed-off-by: Josh Wu > Hi Josh, > > Does this patch apply because of the new enhancement that you had > proposed in "media: atmel-isi: parse the DT parameters for > vsync/hsync/pixclock polarity" or does it apply even before? > Is it a fix that applies to older kernels? It's is a fix, according to the dt binding of video interface. So it should be applied before: "media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity". it has no impact in older kernel as the driver doesn't parse that=20 property yet. > > So, should I wait for the enhancements to enter media git tree or can= I > take them anyway? yes, you can take it without waiting for the media tree. Thanks. Best Regards, Josh Wu > > Bye, > >> --- >> >> arch/arm/boot/dts/at91sam9m10g45ek.dts | 2 ++ >> arch/arm/boot/dts/at91sam9x5ek.dtsi | 2 ++ >> arch/arm/boot/dts/sama5d3xmb.dtsi | 2 ++ >> 3 files changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/= dts/at91sam9m10g45ek.dts >> index d1ae60a..9d16ef8 100644 >> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts >> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts >> @@ -198,6 +198,8 @@ >> isi_0: endpoint { >> remote-endpoint =3D <&ov2640_0>; >> bus-width =3D <8>; >> + vsync-active =3D <1>; >> + hsync-active =3D <1>; >> }; >> }; >> }; >> diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts= /at91sam9x5ek.dtsi >> index d237c46..479f200 100644 >> --- a/arch/arm/boot/dts/at91sam9x5ek.dtsi >> +++ b/arch/arm/boot/dts/at91sam9x5ek.dtsi >> @@ -66,6 +66,8 @@ >> isi_0: endpoint@0 { >> remote-endpoint =3D <&ov2640_0>; >> bus-width =3D <8>; >> + vsync-active =3D <1>; >> + hsync-active =3D <1>; >> }; >> }; >> }; >> diff --git a/arch/arm/boot/dts/sama5d3xmb.dtsi b/arch/arm/boot/dts/s= ama5d3xmb.dtsi >> index 83bee7a..8901042 100644 >> --- a/arch/arm/boot/dts/sama5d3xmb.dtsi >> +++ b/arch/arm/boot/dts/sama5d3xmb.dtsi >> @@ -87,6 +87,8 @@ >> isi_0: endpoint { >> remote-endpoint =3D <&ov2640_0>; >> bus-width =3D <8>; >> + vsync-active =3D <1>; >> + hsync-active =3D <1>; >> }; >> }; >> }; >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html