From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sasha Finkelstein <fnkl.kernel@gmail.com>,
thierry.reding@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: apple: t8103: Add PWM controller
Date: Fri, 28 Oct 2022 13:56:57 -0400 [thread overview]
Message-ID: <55b03c70-cc77-43e7-7ca2-8a0445a40cea@linaro.org> (raw)
In-Reply-To: <20221028165215.43662-4-fnkl.kernel@gmail.com>
On 28/10/2022 12:52, Sasha Finkelstein wrote:
> Adds PWM controller and keyboard backlight bindings for M1 MacBooks
>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
> arch/arm64/boot/dts/apple/t8103-j293.dts | 20 ++++++++++++++++++++
> arch/arm64/boot/dts/apple/t8103-j313.dts | 20 ++++++++++++++++++++
> arch/arm64/boot/dts/apple/t8103.dtsi | 9 +++++++++
> 3 files changed, 49 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index ecb10d237a05..5652cd41730a 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -11,6 +11,7 @@
>
> #include "t8103.dtsi"
> #include "t8103-jxxx.dtsi"
> +#include <dt-bindings/leds/common.h>
>
> / {
> compatible = "apple,j293", "apple,t8103", "apple,arm-platform";
> @@ -43,3 +44,22 @@ &i2c2 {
> &i2c4 {
> status = "okay";
> };
> +
> +/ {
> + pwmleds {
Node names should be generic: led-controller
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "pwm-leds";
> + kbd-backlight {
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
> + pwms = <&fpwm1 0 40000>;
> + label = "kbd_backlight";
> + function = LED_FUNCTION_KBD_BACKLIGHT;
> + color = <LED_COLOR_ID_WHITE>;
> + max-brightness = <255>;
> + default-state = "keep";
> + pwm-names = "kbd-backlight";
This goes just after pwms.
> + };
> + };
> +};
> +
> +&fpwm1 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/apple/t8103-j313.dts b/arch/arm64/boot/dts/apple/t8103-j313.dts
> index df741737b8e6..cff53f8770f3 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j313.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j313.dts
> @@ -11,6 +11,7 @@
>
> #include "t8103.dtsi"
> #include "t8103-jxxx.dtsi"
> +#include <dt-bindings/leds/common.h>
>
> / {
> compatible = "apple,j313", "apple,t8103", "apple,arm-platform";
> @@ -35,3 +36,22 @@ &pcie0_dart_2 {
>
> /delete-node/ &port01;
> /delete-node/ &port02;
> +
> +/ {
> + pwmleds {
Same comments
> + compatible = "pwm-leds";
> + kbd-backlight {
> + pwms = <&fpwm1 0 40000>;
> + label = "kbd_backlight";
> + function = LED_FUNCTION_KBD_BACKLIGHT;
> + color = <LED_COLOR_ID_WHITE>;
> + max-brightness = <255>;
> + default-state = "keep";
> + pwm-names = "kbd-backlight";
> + };
> + };
> +};
> +
> +&fpwm1 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index 51a63b29d404..a95dc482102e 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -191,6 +191,15 @@ i2c4: i2c@235020000 {
> status = "disabled"; /* only used in J293 */
> };
>
> + fpwm1: fpwm@235044000 {
Node names should be generic, so pwm.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "apple,t8103-fpwm", "apple,s5l-fpwm";
> + reg = <0x2 0x35044000 0x0 0x4000>;
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-28 17:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:52 [PATCH 0/4] PWM and keyboard backlight driver for ARM Macs Sasha Finkelstein
2022-10-28 16:52 ` [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller Sasha Finkelstein
2022-10-28 17:53 ` Krzysztof Kozlowski
2022-10-28 18:44 ` Sasha Finkelstein
2022-10-28 19:04 ` Rob Herring
2022-10-28 19:47 ` Krzysztof Kozlowski
2022-10-28 16:52 ` [PATCH 2/4] " Sasha Finkelstein
2022-10-28 17:54 ` Krzysztof Kozlowski
2022-10-28 18:51 ` Sasha Finkelstein
2022-10-28 19:49 ` Krzysztof Kozlowski
2022-10-29 6:25 ` Hector Martin
2022-10-28 16:52 ` [PATCH 3/4] arm64: dts: apple: t8103: Add " Sasha Finkelstein
2022-10-28 17:56 ` Krzysztof Kozlowski [this message]
2022-10-28 16:52 ` [PATCH 4/4] MAINTAINERS: Add entries for Apple PWM driver Sasha Finkelstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55b03c70-cc77-43e7-7ca2-8a0445a40cea@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=fnkl.kernel@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).