From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ACFFC7EE29 for ; Thu, 8 Jun 2023 11:29:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235500AbjFHL3c (ORCPT ); Thu, 8 Jun 2023 07:29:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234375AbjFHL3b (ORCPT ); Thu, 8 Jun 2023 07:29:31 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 474AC2700 for ; Thu, 8 Jun 2023 04:29:30 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-977c8423dccso333766766b.1 for ; Thu, 08 Jun 2023 04:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686223769; x=1688815769; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=onxhXy/B3JaBIheRaBcu5GB2qIrwCPqePPD/9cziBFo=; b=s3HV8OuEuup+OUIbJ5k4zyOUACR6Ln/qHhqYIRPuj9saN1HZYYTvGPIf7KeD92Y32w tArH2SG9wsGi8fJUHZyi+A8MymlkWOi+7ut9qlsEGFkzpnPXfAtmtz2RB5mhkmV6lIeZ cuw93ltGyLAdJZAIIVu0O9oVtvT5zJIuqqcyll4DH9wI8GYZCfonSn6FjAUeXl8MinpQ qgtuoFEqxAwnwovqPCp75vNqwXJmf39EpVe6wWGQsXQ6nPn0U4kK7h3JkhotRNPoTXOu c5PPBkvrHFtGu34YiMkqlvMeRhDC0/pDaPY+L6hpWgLYa0P++rUhWHAdarhwXBOhCAaF ypYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686223769; x=1688815769; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=onxhXy/B3JaBIheRaBcu5GB2qIrwCPqePPD/9cziBFo=; b=fUgZo3y4/6rjvwG7znVlpcBeIQDaplL6hMHea80ZzqGBg5z4UOT36fgzGe03C0B7Dy IO577yHUp6Q+PO5Dzs7VFXiI1kmwWnoW9s0U4ToDsLqYCFh0a7GUTHBxfB4UNHGf+IUQ RdC0Y0qJ5+n5D5E6jhV0g9K1fgn6Gscm6sj44hINZI1LLW/FWZfx8wsS92urzEk0SfYq upG9LI9Ao6C76xr32G7zfxooE2w5KG08E5vSReVGOxFQft9RxBLNbERDmCM9XnVm9m0z XgrlE/59dIcaebHSPtXfKVpZkSVWdCyMwy9JBh2QdLTllaRxYtOoSWTOzP5KYdR5HtFB AVAg== X-Gm-Message-State: AC+VfDzN3ndD+h1Yqt07k0B4vyY8D7QKD2K7pXsWIUx7hbYUi5eLKmPv Tqc2Ti/5nQxxG1v4Wevl0cLtsQ== X-Google-Smtp-Source: ACHHUZ4lxiQ8JILFOmcDga5RplGQDFOtntTdA4bXHBvYEPRfybd9BQhQ9QGU/yYHSxR6das7Cb86Dg== X-Received: by 2002:a17:907:160b:b0:977:d660:c5aa with SMTP id hb11-20020a170907160b00b00977d660c5aamr1742048ejc.31.1686223768778; Thu, 08 Jun 2023 04:29:28 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id h12-20020a1709066d8c00b009745482c5b7sm574674ejt.94.2023.06.08.04.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 04:29:28 -0700 (PDT) Message-ID: <55b59833-d070-f576-9d85-047175d9722c@linaro.org> Date: Thu, 8 Jun 2023 13:29:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 1/2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt to yaml Content-Language: en-US To: "Mehta, Piyush" , Rob Herring Cc: "p.zabel@pengutronix.de" , "Paladugu, Siva Durga Prasad" , "michal.simek@xilinx.com" , "nava.manne@xilinx.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "conor+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "robh+dt@kernel.org" , "Simek, Michal" , "git (AMD-Xilinx)" References: <20230607065121.2265076-1-piyush.mehta@amd.com> <20230607065121.2265076-2-piyush.mehta@amd.com> <168612336438.2153757.6000360498539992409.robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/06/2023 12:55, Mehta, Piyush wrote: > Hello, > >> -----Original Message----- >> From: Rob Herring >> Sent: Wednesday, June 7, 2023 1:06 PM >> To: Mehta, Piyush >> Cc: p.zabel@pengutronix.de; Paladugu, Siva Durga Prasad >> ; michal.simek@xilinx.com; >> nava.manne@xilinx.com; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-usb@vger.kernel.org; conor+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; robh+dt@kernel.org; Simek, Michal >> ; git (AMD-Xilinx) >> Subject: Re: [PATCH 1/2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt >> to yaml >> >> >> On Wed, 07 Jun 2023 12:21:20 +0530, Piyush Mehta wrote: >>> Convert the binding to DT schema format. It also updates the >>> reset-controller description. >>> >>> Signed-off-by: Piyush Mehta >>> --- >>> Note: >>> The 1/2 patch introduced a warning related to the dt binding check, >>> which was subsequently fixed in the 2/2 patch. This warning is a >>> conversion warning due to a dependency on firmware dt binding. >>> >>> Warning: >>> DTC_CHK >>> Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.example.dtb >>> >> /scratch/piyushm/torvalds/linux/Documentation/devicetree/bindings/reset/xln >> x,zynqmp-reset.example.dtb: zynqmp-firmware: 'reset-controller' does not >> match any of the regexes: 'pinctrl-[0-9]+' >>> From schema: >>> /scratch/piyushm/torvalds/linux/Documentation/devicetree/bindings/firm >>> ware/xilinx/xlnx,zynqmp-firmware.yaml >>> >>> Please suggest to me, if it's fine to make a single patch instead of >>> the separate patch 1/2 and 2/2. >>> --- >>> .../bindings/reset/xlnx,zynqmp-reset.txt | 55 --------------- >>> .../bindings/reset/xlnx,zynqmp-reset.yaml | 67 +++++++++++++++++++ >>> 2 files changed, 67 insertions(+), 55 deletions(-) delete mode >>> 100644 Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.txt >>> create mode 100644 >>> Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review- >> ci/linux/Documentation/devicetree/bindings/reset/xlnx,zynqmp- >> reset.example.dtb: zynqmp-firmware: 'reset-controller' does not match any of >> the regexes: 'pinctrl-[0-9]+' >> From schema: /builds/robherring/dt-review- >> ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp- >> firmware.yaml >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree- >> bindings/patch/20230607065121.2265076-2-piyush.mehta@amd.com >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above error(s), >> then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. > > This dt_binding warning is known to us and is captured in commit description notes and to resolve it, we need to apply 2/2. So your patchset has broken bisectability. You need to fix it. If the warning was known, then I am surprised that you sent broken patchset. > I want to take DT maintainer opinion if we should keep the fix in 2/2 or merge it in 1/2. Just avoid the warning. Anyway you need only one complete example, right? Best regards, Krzysztof