public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Durai Manickam KR <durai.manickamkr@microchip.com>,
	<robh+dt@kernel.org>, <alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <Hari.PrasathGE@microchip.com>
Subject: Re: [PATCH] ARM: dts: at91-sama5d2_icp.dts: Added I2C bus recovery support
Date: Tue, 21 Sep 2021 11:17:27 +0200	[thread overview]
Message-ID: <55cb9b7f-f49b-13ce-77e3-1377e714ee45@microchip.com> (raw)
In-Reply-To: <20210921064344.889304-1-durai.manickamkr@microchip.com>

On 21/09/2021 at 08:43, Durai Manickam KR wrote:
> SDA and SCL is configured as GPIO for I2C bus to recover during
> I2C bus malfunction.
> 
> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
And queued on at91-dt for 5.16.

Thanks, best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-sama5d2_icp.dts | 22 ++++++++++++++++++++--
>   1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_icp.dts b/arch/arm/boot/dts/at91-sama5d2_icp.dts
> index e06b58724ca8..806eb1d911d7 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_icp.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_icp.dts
> @@ -307,8 +307,11 @@ regulator-state-mem {
>   };
>   
>   &i2c0 { /* mikrobus i2c */
> -	pinctrl-names = "default";
> +	pinctrl-names = "default", "gpio";
>   	pinctrl-0 = <&pinctrl_mikrobus_i2c>;
> +	pinctrl-1 = <&pinctrl_i2c0_gpio>;
> +	sda-gpios = <&pioA PIN_PD21 GPIO_ACTIVE_HIGH>;
> +	scl-gpios = <&pioA PIN_PD22 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>   	i2c-digital-filter;
>   	i2c-digital-filter-width-ns = <35>;
>   	status = "okay";
> @@ -316,8 +319,11 @@ &i2c0 { /* mikrobus i2c */
>   
>   &i2c1 {
>   	dmas = <0>, <0>;
> -	pinctrl-names = "default";
> +	pinctrl-names = "default", "gpio";
>   	pinctrl-0 = <&pinctrl_i2c1_default>;
> +	pinctrl-1 = <&pinctrl_i2c1_gpio>;
> +	sda-gpios = <&pioA PIN_PD19 GPIO_ACTIVE_HIGH>;
> +	scl-gpios = <&pioA PIN_PD20 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>   	i2c-digital-filter;
>   	i2c-digital-filter-width-ns = <35>;
>   	status = "okay";
> @@ -402,6 +408,12 @@ pinctrl_i2c1_default: i2c1_default {
>   		bias-disable;
>   	};
>   
> +	pinctrl_i2c1_gpio: i2c1_gpio {
> +                pinmux = <PIN_PD19__GPIO>,
> +                         <PIN_PD20__GPIO>;
> +                bias-disable;
> +        };
> +
>   	pinctrl_key_gpio_default: key_gpio_default {
>   		pinmux = <PIN_PD0__GPIO>;
>   		bias-pull-up;
> @@ -463,6 +475,12 @@ pinctrl_mikrobus_i2c: mikrobus_i2c {
>   		bias-disable;
>   	};
>   
> +	pinctrl_i2c0_gpio: i2c0_gpio {
> +		pinmux = <PIN_PD21__GPIO>,
> +			 <PIN_PD22__GPIO>;
> +		bias-disable;
> +	};
> +
>   	pinctrl_mikrobus1_an: mikrobus1_an {
>   		pinmux = <PIN_PD26__GPIO>;
>   		bias-disable;
> 


-- 
Nicolas Ferre

      reply	other threads:[~2021-09-21  9:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21  6:43 [PATCH] ARM: dts: at91-sama5d2_icp.dts: Added I2C bus recovery support Durai Manickam KR
2021-09-21  9:17 ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55cb9b7f-f49b-13ce-77e3-1377e714ee45@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=Hari.PrasathGE@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=durai.manickamkr@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox