From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816A8C001DF for ; Mon, 31 Jul 2023 09:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbjGaJTQ (ORCPT ); Mon, 31 Jul 2023 05:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232224AbjGaJSh (ORCPT ); Mon, 31 Jul 2023 05:18:37 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E119B1BD2 for ; Mon, 31 Jul 2023 02:17:11 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b9b904bb04so64606501fa.1 for ; Mon, 31 Jul 2023 02:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690795028; x=1691399828; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5KvgIxXrNBW+ICpRpcD8ldB4nPJk8pR1BpuMuP6iUoA=; b=jyDUsroFZnsQwdHDhpyfjJP16KxJ2Bm3z32mGNUxbV5AHato4TcsXK7RKrVP2LJdY/ 2/4KGWkwKj29qTEg3NPF/FF7ee8ZQGx+k2qRXcWjefmx6ibIi9+xy3R1razFVaP1PFKa 6Jtl+rqNRvuQfxLSu2mx15L9eQdM6902mvBKTDu+aS3k0rzLZD0oHUK6UxauVZYKtyY4 c7br/qTJpA4rq1rdijEybfTYzdxfZH2WJnNUYaEMM+NKQjZxgi45XY5eJ1hx75KxqwKM fYorjbTqUmbPTZzEIVRr+Jhvxzwd6OBdNAwC6anYBfq0jTLVYDUpyc2MP48HJS/4qJlg S3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690795028; x=1691399828; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5KvgIxXrNBW+ICpRpcD8ldB4nPJk8pR1BpuMuP6iUoA=; b=hv4eJKeaxHi8FMwnxCIFTPbGhax3yV6Bkm8x1QD3inCUodniFW7wP1T+up8NdYJ53i BTtD88AH47lcpR7/6/V4tak+bLAF//MLr4M5b4Og6hFQ/5E/mG8ySiW7Frs1jCCQpuuh qQIpXscC0jAayX7C+X6+069DrD8IGJcOV9kwMqZapyOIwPpo+3VuoomhdFHD8LFBYyaZ +KROdMSpdLm0G/5k++4lfB21peVFLPkCketT4wj53PgjC6LZgVHpT1Yt7epBaYpsrfXN iCB0cXAo0I1+pBeW082zTV5A4ubsf0NIqs6OH2y2ZNKDm3TzQcJIn/qfm2tnf1pG8k+B SaSw== X-Gm-Message-State: ABy/qLbRxAm//D4ZL72L6fnF44ahdLYHZILSgb+vwie27NC8zzpaIcWE vEQIGNj/btVQbjFrBBcvIMPFWg== X-Google-Smtp-Source: APBJJlFhbontxRh2AYxqpfnm5ytn+b3cKOcZKI0ursWXowN0xpSywbzEKe4jSNS+2JWGR7yjRKMYcg== X-Received: by 2002:a2e:910f:0:b0:2b9:5695:d10d with SMTP id m15-20020a2e910f000000b002b95695d10dmr5741521ljg.36.1690795028263; Mon, 31 Jul 2023 02:17:08 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:14b8:9aa7:6bf0:256d? ([2a01:e0a:982:cbb0:14b8:9aa7:6bf0:256d]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c225400b003fbe791a0e8sm10745362wmm.0.2023.07.31.02.17.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 02:17:07 -0700 (PDT) Message-ID: <55cbdbba-39c6-7415-37db-97d2c35412cb@linaro.org> Date: Mon, 31 Jul 2023 11:17:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic C3 Reset Controller Content-Language: en-US To: Philipp Zabel , zelong dong , Kevin Hilman , Rob Herring , Martin Blumenstingl , Jerome Brunet Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, kelvin.zhang@amlogic.com References: <20230719060954.14864-1-zelong.dong@amlogic.com> <20230719060954.14864-2-zelong.dong@amlogic.com> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/07/2023 17:49, Philipp Zabel wrote: > On Mi, 2023-07-19 at 14:09 +0800, zelong dong wrote: >> From: Zelong Dong >> >> Add new compatible and DT bindings for Amlogic C3 Reset Controller >> >> Signed-off-by: Zelong Dong >> --- >> .../bindings/reset/amlogic,meson-reset.yaml | 1 + >> include/dt-bindings/reset/amlogic,c3-reset.h | 119 ++++++++++++++++++ >> 2 files changed, 120 insertions(+) >> create mode 100644 include/dt-bindings/reset/amlogic,c3-reset.h >> >> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml >> index d3fdee89d4f8..f0c6c0df0ce3 100644 >> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml >> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml >> @@ -18,6 +18,7 @@ properties: >> - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs >> - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs >> - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs >> + - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs >> >> reg: >> maxItems: 1 >> diff --git a/include/dt-bindings/reset/amlogic,c3-reset.h b/include/dt-bindings/reset/amlogic,c3-reset.h >> new file mode 100644 >> index 000000000000..d9127863f603 >> --- /dev/null >> +++ b/include/dt-bindings/reset/amlogic,c3-reset.h > > Given that this is only included by > arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi, should this header be > moved to arch/arm64/boot/dts/amlogic ? Maybe I missed something, but since when should we move bindings headers to arch/xxx/boot/dts/vendor ? Neil > > regards > Philipp