From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported References: <36f4b1736e36b039af15b13645df0de492f1b6e1.1476462204.git.lolivei@synopsys.com> <20161014173014.GA26269@leverpostej> <20161014182045.GA1509@katana> From: Ramiro Oliveira Message-ID: <55cc91af-8d24-8aea-f74f-2ef40cd8ea5a@synopsys.com> Date: Tue, 18 Oct 2016 15:51:55 +0100 MIME-Version: 1.0 In-Reply-To: <20161014182045.GA1509@katana> Content-Type: multipart/alternative; boundary="------------09962F792FB9EFC5574A3ADC" To: Wolfram Sang , Mark Rutland Cc: Luis.Oliveira@synopsys.com, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, CARLOS.PALMINHA@synopsys.com, Ramiro.Oliveira@synopsys.com List-ID: --------------09962F792FB9EFC5574A3ADC Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit On 10/14/2016 7:20 PM, Wolfram Sang wrote: > On Fri, Oct 14, 2016 at 06:30:15PM +0100, Mark Rutland wrote: >> On Fri, Oct 14, 2016 at 05:52:50PM +0100, Luis.Oliveira@synopsys.com wrote: >>> - is_slave = device_property_read_bool(&pdev->dev, "isslave"); >> Which tree is this based on? I cant see the existing isslave property in >> mainline HEAD (commit 29fbff8698fc0ac1). > Same surprise here. Because I likely would have NAKed the binding. > > Why is it needed? Doesn't the driver allow to be master/slave on the > same bus? > I'm replying for Lu�s, since at the moment he's not able to reply. This is needed because the configuration is different and the i2c-designware cannot be master/slave without a reset. To resolve that I added this property to bind it as a slave when needed. BRs, Ramiro --------------09962F792FB9EFC5574A3ADC Content-Type: text/html; charset="windows-1252" Content-Transfer-Encoding: 8bit On 10/14/2016 7:20 PM, Wolfram Sang wrote:
On Fri, Oct 14, 2016 at 06:30:15PM +0100, Mark Rutland wrote:

On Fri, Oct 14, 2016 at 05:52:50PM +0100, Luis.Oliveira@synopsys.com wrote:

-		is_slave = device_property_read_bool(&pdev->dev, "isslave");

Which tree is this based on? I cant see the existing isslave property in
mainline HEAD (commit 29fbff8698fc0ac1).

Same surprise here. Because I likely would have NAKed the binding.

Why is it needed? Doesn't the driver allow to be master/slave on the
same bus?
I'm replying for Lu�s, since at the moment he's not able to reply.

This is needed because the configuration is different and the i2c-designware cannot be master/slave without a reset. To resolve that I added this property to bind it as a slave when needed.

BRs,
Ramiro

--------------09962F792FB9EFC5574A3ADC--