From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 297E818C35F for ; Wed, 26 Jun 2024 15:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719416603; cv=none; b=SO2brD7dX/OemZKoYmqRcMaYwDl3oNQ/bF57aGKYKBeVjhvaQu56MbGLVb73JyAZjES0FFhjL0tYn3wwgJFIicJ9+MSbeC9F7nOQ7rbVF8RQb+YskikfH5lRNEZQKT3k8mnBv+uwTtQOjXPDumAgmpgRN8j3ONAbyGaaDH2uSpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719416603; c=relaxed/simple; bh=yBf7BjQ0TET4RNxCRr0z5OE/8zpvjn5itH58dt/E6Yg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fydTSYBBV+k1MZ4W+9pWylO6odSVWlOjmRX0ZnxIrklWRjkLxr6sZXApTDUAFtxNv798zNXuIAMdpBGZr1q0nEwH5Uv4SxkIO0uRFcrWJy2pVjmIJARUj/hwTl3q9XsUQ0izLAGmfzkNtixzRb+8YDmnGe1a3c95aDvtOOT/IPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=V3ziSCsC; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="V3ziSCsC" Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-5b9706c84e5so3755473eaf.1 for ; Wed, 26 Jun 2024 08:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1719416599; x=1720021399; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L4BM1nm1eXhxPHZf+r3STp6lra6HVOKE5lqVSxFWKI8=; b=V3ziSCsCzMt0neFs88m41XqYWpLG9SFFsvujEHfu9zOCfNUjRIdZS2Ak0EtyDiiSu+ XeApb+hq1rFUGyG23Qcu9aeAdgCaGV2n6RMRMtoGh9Ha6RYbcB3+nLdw5Z81sQQcjndx EN5jgYvQtH6x3Vl2tFLfe84J6kqnBSux9aCBHaGH9/87iTQiQjzGH/vrBaRP5LxH9qZv Iiut6hJKvMOJCTDSnCpas2/kNvaIoaOOZLOA2rvG6aFygi6p6CU2hZYBnRZqkiE4x9Er /IiSel4DQKSYHMuPw9SjJ8wcigiQ+s6luE+l+piFpNXrvlRRLA6YgN0BKkhDoUXLXThy D0qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719416599; x=1720021399; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L4BM1nm1eXhxPHZf+r3STp6lra6HVOKE5lqVSxFWKI8=; b=jypmmcBuENOnKmLobVai8jnvHpfh7+lp+vAHPv8BgjytRX2hxGgJQzP3Xofl7m5+Od 4Efb9djsc+weUkG+5ojNZQkqpn/XZWZfsSR+9/SErs7rZkyMUyTQidZBTv1OH/VfZL35 I+WkL9+MDWBhVvvP67n5VJ5hdvH1MM7lyX8bYqek6qurxC5gNOVA/qqgEi64N7brGUba w9eBa691/3KL9DgPtIrzO6NaarfTrYcoCikD0BpXMkgB67LbjlN1OlbuWFKyXvSsqKas EbLX3GELwWEiKm5KyilMY5z7D75sKC81W81+flA+QCkjD/2PlE+xDjFLQ0nbkeUe1MXc JO7A== X-Forwarded-Encrypted: i=1; AJvYcCW6auwHWEBrp+HH9nhNv1ZT2DpgvDYteqOZBk9GqpxQCAfUdsFFFB1d6L0m+Sjets0DKx2JkJTLW2yWWnRvosnFM5DCWArruClbDQ== X-Gm-Message-State: AOJu0YyygVObEA805FpKCDPxVL4Yp0RUQMXi6o+9K6VNs52nez/gEAj0 jX0449KIM6sfQv0Tg/sq3r8cAitFQgAcLJzP5rzQtMdwh/Jh07ZYAX0tz55/MkI= X-Google-Smtp-Source: AGHT+IGx7aFcTxf1GenpaKQHv67xvK5YmcOttQKW/seQI/OiieGIay/0iltoy3aIGzodsou6GFy57A== X-Received: by 2002:a4a:8515:0:b0:5ba:ffcb:c760 with SMTP id 006d021491bc7-5c1ebb01d47mr11473795eaf.5.1719416598936; Wed, 26 Jun 2024 08:43:18 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5c1d58ff8f4sm2162338eaf.41.2024.06.26.08.43.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jun 2024 08:43:18 -0700 (PDT) Message-ID: <55d0cc07-c877-4510-a052-4458ee964615@baylibre.com> Date: Wed, 26 Jun 2024 10:43:17 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 7/7] docs: iio: Add documentation for AD4000 To: Marcelo Schmitt , broonie@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nuno.sa@analog.com, corbet@lwn.net, marcelo.schmitt1@gmail.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/25/24 4:55 PM, Marcelo Schmitt wrote: > Document wiring configurations for the AD4000 series of ADCs. > > Signed-off-by: Marcelo Schmitt > --- > Documentation/iio/ad4000.rst | 131 +++++++++++++++++++++++++++++++++++ > Documentation/iio/index.rst | 1 + > MAINTAINERS | 1 + > 3 files changed, 133 insertions(+) > create mode 100644 Documentation/iio/ad4000.rst > > diff --git a/Documentation/iio/ad4000.rst b/Documentation/iio/ad4000.rst > new file mode 100644 > index 000000000000..de8fd3ae6e62 > --- /dev/null > +++ b/Documentation/iio/ad4000.rst > @@ -0,0 +1,131 @@ > +.. SPDX-License-Identifier: GPL-2.0-only > + > +============= > +AD4000 driver > +============= > + > +Device driver for Analog Devices Inc. AD4000 series of ADCs. > + > +Supported devices > +================= > + > +* `AD4000 `_ > +* `AD4001 `_ > +* `AD4002 `_ > +* `AD4003 `_ > +* `AD4004 `_ > +* `AD4005 `_ > +* `AD4006 `_ > +* `AD4007 `_ > +* `AD4008 `_ > +* `AD4010 `_ > +* `AD4011 `_ > +* `AD4020 `_ > +* `AD4021 `_ > +* `AD4022 `_ > +* `ADAQ4001 `_ > +* `ADAQ4003 `_ > + > +Wiring connections > +------------------ > + > +Devices of the AD4000 series can be connected to the SPI host controller in a > +few different modes. > + > +CS mode, 3-wire turbo mode > +^^^^^^^^^^^^^^^^^^^^^^^^^^ The datasheet also has the same diagram in _Figure 55. CS Mode, 4-Wire Turbo Mode Connection Diagram_. So maybe we should call this "register support mode" or something like that instead of mentioning 3 or 4-wire? > + > +Datasheet "3-wire" mode is what most resembles standard SPI connection which, > +for these devices, comprises of connecting the controller CS line to device CNV > +pin and other SPI lines as usual. This configuration is (misleadingly) called > +"CS Mode, 3-Wire Turbo Mode" connection in datasheets. > +NOTE: The datasheet definition of 3-wire mode for the AD4000 series is NOT the > +same of standard spi-3wire mode. > +This is the only connection mode that allows configuration register access but > +it requires the SPI controller to support the ``SPI_MOSI_IDLE_HIGH`` feature. > + > +Omit the ``adi,sdi-pin`` property in device tree to select this mode. > + > +:: > + > + +-------------+ > + + ----------------------------------| SDO | > + | | | > + | +-------------------| CS | > + | v | | > + | +--------------------+ | HOST | > + | | CNV | | | > + +--->| SDI AD4000 SDO |-------->| SDI | > + | SCK | | | > + +--------------------+ | | > + ^ | | > + +--------------------| SCLK | > + +-------------+ > + I think the rest of the explanations are good.