From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCH RFC v4 2/8] ALSA: pcm: add IEC958 channel status helper for hw_params Date: Mon, 21 Sep 2015 20:25:46 +0300 Message-ID: <56003D9A.5060009@ti.com> References: <20150921093748.GG21098@n2100.arm.linux.org.uk> <560016BE.6010801@ti.com> <56001D5F.1010903@ladisch.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56001D5F.1010903@ladisch.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Clemens Ladisch , Russell King - ARM Linux Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, liam.r.girdwood@linux.intel.com, moinejf@free.fr, airlied@linux.ie, broonie@kernel.org, dri-devel@lists.freedesktop.org, peter.ujfalusi@ti.com, Takashi Iwai , tony@atomide.com, tomi.valkeinen@ti.com, bcousson@baylibre.com, linux-omap@vger.kernel.org List-Id: devicetree@vger.kernel.org On 09/21/15 18:08, Clemens Ladisch wrote: >> >But there is no downside in using prepare callback. > The prepare callback also can be called multiple times. This certainly > happens when the stream is stopped/restarted multiple times. > > If something does not need to be done again when a stream is restarted, > then it should be done in the hw_params callback. Oh, forgot about that. This would suggest to keep the stream header configuration in the hw_params(). Thanks, Jyri