From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66E8FC04A94 for ; Fri, 21 Jul 2023 14:04:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231426AbjGUOEq (ORCPT ); Fri, 21 Jul 2023 10:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjGUOEo (ORCPT ); Fri, 21 Jul 2023 10:04:44 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34F8DFD for ; Fri, 21 Jul 2023 07:04:41 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fc03aa6e04so16466545e9.2 for ; Fri, 21 Jul 2023 07:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689948279; x=1690553079; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i0hqft4rLykA1Qm+aWWngJrri1KXMWVHpmrflE+PpLU=; b=KzPxa8KXQz5MfDDt2Hr8NCdHH7Er0bPAv4YoqoUulZL1A8MaW/bte3T3bZOaEAFzNk w7TwDzBzdkd+MfZmcsSfoFDYZqgPdOWH/zIlJq+LLZ1Vbj5su7wnHbzRpJr6idQpOQkD TMXdIAYABzBME16eyIKHrRCF5J5lYTJRHp+a5ylZ/xWp0yyhZkyrV1z8RjyxGweXTwcx qKx+GVxwZG1dv3OUuLAHhBNV793Wvoh6bVToxBmIU9Z2bWRRFxoY/A80A3Rs1rQFoqlE ykdC2iiTvU9r5XMzHOiUfLIC8odjwnJLl1L7bI4Sv0CIkQSSatzOfTp3PslQcKdZ00Fw hnLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689948279; x=1690553079; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i0hqft4rLykA1Qm+aWWngJrri1KXMWVHpmrflE+PpLU=; b=iUUo39UJqJizAIUvyFJgfeZ5/vq4fXOrOEDi4CNTNDdRXx1/RgDOssQHIYhx99kwSA ShCHMEROS3/O6O+yHxDF2v9UEmTcQpxvNoqnQBqRIxvqoXLTDgEvPWG6nKAyagZi0qKN Mcxe1hYEYWx3LN7n09vcMEcP7CIGxmC0chEoCRLl+6991SZqpXyGKVd7W3AMuix2O0gF jixgQ7PBhYp87InwmgKespRbUXTODFc+Uh55bP+W6qfjeYM9KFpgyVcOqGsYqvfAcNM6 o4lgKMWDN9iaUaIJdfMD4A67KNmJ2mzVAkfBVGJY7HPVXwIdbBWiykEmH8OgqJMtl+yT JkaQ== X-Gm-Message-State: ABy/qLZ+f0N7mutM0KPjzGtnJvPCyA5qlVt1hBJ17HdUqBmSDvgSIkbe 5tRM4VSqB1uKYr4p7DPOgVTRQg== X-Google-Smtp-Source: APBJJlEsMYe5JQ+pU4AezELFYdRQHmI7TefsDs6cDm78/h68oOlcICdvW129lDjtJ/t6VHgFfG467Q== X-Received: by 2002:adf:fc03:0:b0:314:1634:491e with SMTP id i3-20020adffc03000000b003141634491emr1269926wrr.20.1689948279591; Fri, 21 Jul 2023 07:04:39 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id x8-20020a1c7c08000000b003f90b9b2c31sm6142028wmc.28.2023.07.21.07.04.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 07:04:38 -0700 (PDT) Message-ID: <5603264e-2efe-48ce-b025-797501f29fde@linaro.org> Date: Fri, 21 Jul 2023 16:04:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 06/42] dt-bindings: soc: Add Cirrus EP93xx Content-Language: en-US To: nikita.shubin@maquefel.me, Hartley Sweeten , Lennert Buytenhek , Alexander Sverdlin , Russell King , Lukasz Majewski , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Daniel Lezcano , Thomas Gleixner , Alessandro Zummo , Alexandre Belloni , Wim Van Sebroeck , Guenter Roeck , Sebastian Reichel , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Mark Brown , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Damien Le Moal , Sergey Shtylyov , Dmitry Torokhov , Arnd Bergmann , Olof Johansson , soc@kernel.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Andy Shevchenko , Michael Peters , Kris Bahnsen Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, linux-ide@vger.kernel.org, linux-input@vger.kernel.org, alsa-devel@alsa-project.org References: <20230605-ep93xx-v3-0-3d63a5f1103e@maquefel.me> <20230605-ep93xx-v3-6-3d63a5f1103e@maquefel.me> From: Krzysztof Kozlowski In-Reply-To: <20230605-ep93xx-v3-6-3d63a5f1103e@maquefel.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/07/2023 13:29, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin > > This adds device tree bindings for the Cirrus Logic EP93xx. > > Signed-off-by: Nikita Shubin > --- > .../bindings/arm/cirrus/ep9301-syscon.yaml | 59 ++++++++++++++++++++++ syscon goes to soc directory. Also, please add vendor prefix to the filenames. > .../devicetree/bindings/arm/cirrus/ep9301.yaml | 39 ++++++++++++++ > 2 files changed, 98 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml b/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml > new file mode 100644 > index 000000000000..77fbe1f006fd > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/cirrus/ep9301-syscon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP93xx Platforms System Controller > + > +maintainers: > + - Alexander Sverdlin > + - Nikita Shubin > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - cirrus,ep9302-syscon > + - cirrus,ep9307-syscon > + - cirrus,ep9312-syscon > + - cirrus,ep9315-syscon > + - const: cirrus,ep9301-syscon > + - const: syscon > + - const: simple-mfd > + - items: > + - const: cirrus,ep9301-syscon > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + reboot: > + type: object > + properties: > + compatible: > + const: cirrus,ep9301-reboot Patch introducing it should be before this one. Also, do not use different styles for your child nodes. Your other nodes use $ref. > + > + clock-controller: > + type: object > + $ref: ../../clock/cirrus,ep9301-clk.yaml Absolute path, so /schemas/clock/cirrus..... > + > + pinctrl: > + type: object > + $ref: ../../pinctrl/cirrus,ep9301-pinctrl.yaml Ditto > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + syscon@80930000 { > + compatible = "cirrus,ep9301-syscon", > + "syscon", "simple-mfd"; > + reg = <0x80930000 0x1000>; Incomplete example. > + }; > diff --git a/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml b/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml > new file mode 100644 > index 000000000000..6087784e93fb > --- /dev/null Best regards, Krzysztof