From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96056C35674 for ; Sat, 22 Feb 2020 20:42:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F71220707 for ; Sat, 22 Feb 2020 20:42:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="KfFZENIH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726856AbgBVUmd (ORCPT ); Sat, 22 Feb 2020 15:42:33 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:42177 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726881AbgBVUmc (ORCPT ); Sat, 22 Feb 2020 15:42:32 -0500 Received: by mail-lf1-f68.google.com with SMTP id 83so4000269lfh.9 for ; Sat, 22 Feb 2020 12:42:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8/dqp+6ZkvRRmpmaUZJPJGMl+JnMMGYivypZ+qu1IdQ=; b=KfFZENIHa1kD6D/djqtV3blmirkAzxujGlBUFJP08Yxr+SBEzFzJLYLcEkkSqydT8X WcrEABFsSj/iama8pmWwrD0OkIPADuTDhFwjkBQNCgz/X0EWGkD1A4XiSLivvtseRDn3 TYiTvAMUlNv9hyetNnMvhIBTGGb1OuWpsVfnhJ58Ho9wGJ0wB9TYgJ5UCENxnu42+3oN 6xdXDF7aUEKvAcq1gbBTewL0jcm8+bY6gCsU9i2lqP/47SV9kF6bH2y1LxAWkiCHpe0t kV/STK4XxyKUpd3IzE0SYkQyeH3TH8R8H0taoZJWSQCs2wPxYJJrzMW7vncAb+rmRqgS m6ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8/dqp+6ZkvRRmpmaUZJPJGMl+JnMMGYivypZ+qu1IdQ=; b=fkrRREX/4NyExJY5GRmvDd5EWKt5XYJsm5h2g8yJO9QcPXG2ImqJigNWvst1LaEmp6 reE2y+RKNTVi8l2dExLi5WFBr2wgPCq1Qj4Vqd5GSL+URwcsG+zGKHXLJrxrDj7S/W4L CbXrkTZIeUSmGZ921DPMS6+qjfIveDe0wJ6WOUwSAT6CoPm3z8Mu2vogAoJWp4uVQw8r xGVV8GdPEkUImvoXdH/hzys8+b2HL1+pQxBpXVRWKT9crrQU2asrqI34Xm+I9tuRKcMU w/j+2mMf/VVspjMLKz4GpkZU38C1fGG/ivyPhChBwK/xpg7Kjagw9jPNTeQ95+ibGBML jvxw== X-Gm-Message-State: APjAAAUM1MgDgQv8MQaXDRMZi2osuxLXyT541vQQzK5eH+s6fmjYYBmm kOstTBVtwWQ6Min2Z4swNARvjQ== X-Google-Smtp-Source: APXvYqx/B38YxteGwSNzJbkis53V2cy++o3q6ZdclQVcDwud+2NQuhy0RoD9Gg/qpGXsI9f1WGPORw== X-Received: by 2002:a19:6b0e:: with SMTP id d14mr4043585lfa.46.1582404149341; Sat, 22 Feb 2020 12:42:29 -0800 (PST) Received: from wasted.cogentembedded.com ([2a00:1fa0:4621:26b8:f6bb:b31c:6567:7228]) by smtp.gmail.com with ESMTPSA id v16sm3543019lfp.92.2020.02.22.12.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Feb 2020 12:42:28 -0800 (PST) Subject: Re: [PATCH RFC 2/2] memory: add Renesas RPC-IF driver To: "Behme Dirk (CM/ESO2)" Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Zabel , Mason Yang , linux-spi@vger.kernel.org, Chris Brandt , linux-renesas-soc@vger.kernel.org References: <4db876ed-1ccc-e3be-311d-30cd52f40259@cogentembedded.com> <5760bcdb-e44b-6f18-7262-9526684e5780@de.bosch.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <5603f393-554d-e2a8-c2d8-6bafc20f4169@cogentembedded.com> Date: Sat, 22 Feb 2020 23:42:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <5760bcdb-e44b-6f18-7262-9526684e5780@de.bosch.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/10/2020 01:21 PM, Behme Dirk (CM/ESO2) wrote: >> Add the memory driver for Renesas RPC-IF which registers either SPI or >> HyperFLash device depending on the contents of the device tree subnode. >> It also provides the absract "back end" device APIs that can be used by >> the "front end" SPI/MTD drivers to talk to the real hardware. >> >> Based on the original patch by Mason Yang . >> >> Signed-off-by: Sergei Shtylyov > > > FYI, please find below [1] the changes I did locally on this driver. It seems to read & write successfully on my custom M3 (R8A7796) device, now. Not for me... BTW, your patch had whitespace ruined, I had to apply it by hand, you'd better attach the patches, not paste. :-/ > Best regards > > Dirk > > [1] > > From d72b805cc461ab1e9747c973e9be84e7abb8f828 Mon Sep 17 00:00:00 2001 > From: Dirk Behme > Date: Tue, 4 Feb 2020 08:39:31 +0100 > Subject: [PATCH] memory: renesas-rpc-if: Correct the STRTIM and some other > clean up > > This is required to make the driver work correctly in my M3 environment. > > Signed-off-by: Dirk Behme > --- > drivers/memory/renesas-rpc-if.c | 42 ++++++++++++++++++++------------- > 1 file changed, 25 insertions(+), 17 deletions(-) > > diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c > index 04be92b64bfa..f4356b066384 100644 > --- a/drivers/memory/renesas-rpc-if.c > +++ b/drivers/memory/renesas-rpc-if.c [...] > @@ -513,19 +525,15 @@ ssize_t rpcif_dirmap_read(struct rpcif *rpc, u64 offs, size_t len, void *buf) > pm_runtime_get_sync(rpc->dev); > > regmap_update_bits(rpc->regmap, RPCIF_CMNCR, RPCIF_CMNCR_MD, 0); > - regmap_write(rpc->regmap, RPCIF_DRCR, > - RPCIF_DRCR_RBURST(32) | RPCIF_DRCR_RBE); > - regmap_write(rpc->regmap, RPCIF_DRCMR, rpc->command); > - regmap_write(rpc->regmap, RPCIF_DREAR, > - RPCIF_DREAR_EAV(offs >> 25) | RPCIF_DREAR_EAC(1)); > - regmap_write(rpc->regmap, RPCIF_DROPR, rpc->option); > - regmap_write(rpc->regmap, RPCIF_DRENR, > - rpc->enable & ~RPCIF_SMENR_SPIDE(0xF)); > - regmap_write(rpc->regmap, RPCIF_DRDMCR, rpc->dummy); > - regmap_write(rpc->regmap, RPCIF_DRDRENR, rpc->ddr); The driver somehow works only with this left in place (with 2 bytes eaten as before), otherwise all the flash reads all 0xff (via dirmap). > + ret = wait_msg_xfer_end(rpc); > + if (ret) { > + len = 0; > + goto err_out; > + } > > memcpy_fromio(buf, rpc->dirmap + from, len); > > +err_out: > pm_runtime_put(rpc->dev); > > return len; MBR, Sergei