* [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx
@ 2015-09-24 14:44 Peter Rosin
2015-09-24 14:47 ` Alexandre Belloni
0 siblings, 1 reply; 6+ messages in thread
From: Peter Rosin @ 2015-09-24 14:44 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Peter Rosin, Nicolas Ferre, Alexandre Belloni,
Jean-Christophe Plagniol-Villard, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
linux-kernel, peda, stable
From: Peter Rosin <peda@axentia.se>
It seems pointless to pullup the tx line, but there is value in pulling
up the rx line.
Cc: stable@vger.kernel.org
Signed-off-by: Peter Rosin <peda@axentia.se>
---
arch/arm/boot/dts/sama5d3.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index 9e2444b07bce..304a40c5552a 100644
--- a/arch/arm/boot/dts/sama5d3.dtsi
+++ b/arch/arm/boot/dts/sama5d3.dtsi
@@ -545,8 +545,8 @@
dbgu {
pinctrl_dbgu: dbgu-0 {
atmel,pins =
- <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_NONE /* PB30 periph A */
- AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PB31 periph A with pullup */
+ <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP /* PB30 periph A with pullup */
+ AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PB31 periph A */
};
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx
2015-09-24 14:44 [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx Peter Rosin
@ 2015-09-24 14:47 ` Alexandre Belloni
[not found] ` <20150924144753.GY4287-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2016-10-16 10:57 ` Peter Rosin
0 siblings, 2 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-09-24 14:47 UTC (permalink / raw)
To: Peter Rosin
Cc: linux-arm-kernel, Peter Rosin, Nicolas Ferre,
Jean-Christophe Plagniol-Villard, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
linux-kernel, stable
Hi Peter,
Thanks for the patch but you actually got beaten by Sylvain:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368426.html
On 24/09/2015 at 16:44:15 +0200, Peter Rosin wrote :
> From: Peter Rosin <peda@axentia.se>
>
> It seems pointless to pullup the tx line, but there is value in pulling
> up the rx line.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> arch/arm/boot/dts/sama5d3.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index 9e2444b07bce..304a40c5552a 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -545,8 +545,8 @@
> dbgu {
> pinctrl_dbgu: dbgu-0 {
> atmel,pins =
> - <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_NONE /* PB30 periph A */
> - AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PB31 periph A with pullup */
> + <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP /* PB30 periph A with pullup */
> + AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PB31 periph A */
> };
> };
>
> --
> 1.7.10.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <20150924144753.GY4287-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>]
* Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx
[not found] ` <20150924144753.GY4287-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
@ 2015-09-24 15:22 ` Peter Rosin
2015-09-24 16:27 ` Alexandre Belloni
0 siblings, 1 reply; 6+ messages in thread
From: Peter Rosin @ 2015-09-24 15:22 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Peter Rosin,
Nicolas Ferre, Jean-Christophe Plagniol-Villard, Rob Herring,
Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
stable-u79uwXL29TY76Z2rM5mHXA
On 2015-09-24 16:47, Alexandre Belloni wrote:
> Hi Peter,
>
> Thanks for the patch but you actually got beaten by Sylvain:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368426.html
Ok, great!
I just noticed that other ports have the same problem in sama5d3.dtsi. E.g.
uart1 {
pinctrl_uart1: uart1-0 {
atmel,pins =
<AT91_PIOA 30 AT91_PERIPH_B AT91_PINCTRL_NONE /* conflicts with TWD0, ISI_VSYNC */
AT91_PIOA 31 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>; /* conflicts with TWCK0, ISI_HSYNC */
};
};
Given that the original bug I found spread all over the map, it seems
like someone was confused when the pull-ups were originally added.
Someone (else?) at Atmel needs to audit this so that pull-ups are
added on the rx-pins instead of the tx-pins.
Cheers,
Peter
> On 24/09/2015 at 16:44:15 +0200, Peter Rosin wrote :
>> From: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
>>
>> It seems pointless to pullup the tx line, but there is value in pulling
>> up the rx line.
>>
>> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Signed-off-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
>> ---
>> arch/arm/boot/dts/sama5d3.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
>> index 9e2444b07bce..304a40c5552a 100644
>> --- a/arch/arm/boot/dts/sama5d3.dtsi
>> +++ b/arch/arm/boot/dts/sama5d3.dtsi
>> @@ -545,8 +545,8 @@
>> dbgu {
>> pinctrl_dbgu: dbgu-0 {
>> atmel,pins =
>> - <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_NONE /* PB30 periph A */
>> - AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PB31 periph A with pullup */
>> + <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP /* PB30 periph A with pullup */
>> + AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PB31 periph A */
>> };
>> };
>>
>> --
>> 1.7.10.4
>>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx
2015-09-24 15:22 ` Peter Rosin
@ 2015-09-24 16:27 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-09-24 16:27 UTC (permalink / raw)
To: Peter Rosin
Cc: linux-arm-kernel, Peter Rosin, Nicolas Ferre,
Jean-Christophe Plagniol-Villard, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
linux-kernel, stable
On 24/09/2015 at 17:22:54 +0200, Peter Rosin wrote :
> I just noticed that other ports have the same problem in sama5d3.dtsi. E.g.
>
> uart1 {
> pinctrl_uart1: uart1-0 {
> atmel,pins =
> <AT91_PIOA 30 AT91_PERIPH_B AT91_PINCTRL_NONE /* conflicts with TWD0, ISI_VSYNC */
> AT91_PIOA 31 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>; /* conflicts with TWCK0, ISI_HSYNC */
> };
> };
>
> Given that the original bug I found spread all over the map, it seems
> like someone was confused when the pull-ups were originally added.
> Someone (else?) at Atmel needs to audit this so that pull-ups are
> added on the rx-pins instead of the tx-pins.
>
Sure, that is the plan!
Thanks again for the report.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx
2015-09-24 14:47 ` Alexandre Belloni
[not found] ` <20150924144753.GY4287-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
@ 2016-10-16 10:57 ` Peter Rosin
2016-10-16 16:43 ` Sylvain Rochet
1 sibling, 1 reply; 6+ messages in thread
From: Peter Rosin @ 2016-10-16 10:57 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Mark Rutland, devicetree, Russell King, Pawel Moll, Ian Campbell,
Sylvain Rochet, Nicolas Ferre, linux-kernel, Rob Herring,
Kumar Gala, Jean-Christophe Plagniol-Villard, Peter Rosin,
linux-arm-kernel
Hi again,
I forgot about this, and it's been a year. But isn't it time to
upstream those pull-up fixes that Sylvain provided?
Cheers,
Peter
On 2015-09-24 16:47, Alexandre Belloni wrote:
> Hi Peter,
>
> Thanks for the patch but you actually got beaten by Sylvain:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368426.html
>
> On 24/09/2015 at 16:44:15 +0200, Peter Rosin wrote :
>> From: Peter Rosin <peda@axentia.se>
>>
>> It seems pointless to pullup the tx line, but there is value in pulling
>> up the rx line.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>> ---
>> arch/arm/boot/dts/sama5d3.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
>> index 9e2444b07bce..304a40c5552a 100644
>> --- a/arch/arm/boot/dts/sama5d3.dtsi
>> +++ b/arch/arm/boot/dts/sama5d3.dtsi
>> @@ -545,8 +545,8 @@
>> dbgu {
>> pinctrl_dbgu: dbgu-0 {
>> atmel,pins =
>> - <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_NONE /* PB30 periph A */
>> - AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PB31 periph A with pullup */
>> + <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP /* PB30 periph A with pullup */
>> + AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PB31 periph A */
>> };
>> };
>>
>> --
>> 1.7.10.4
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx
2016-10-16 10:57 ` Peter Rosin
@ 2016-10-16 16:43 ` Sylvain Rochet
0 siblings, 0 replies; 6+ messages in thread
From: Sylvain Rochet @ 2016-10-16 16:43 UTC (permalink / raw)
To: Peter Rosin
Cc: Mark Rutland, devicetree, Russell King, Pawel Moll, Ian Campbell,
Nicolas Ferre, linux-kernel, Rob Herring, Alexandre Belloni,
Kumar Gala, Jean-Christophe Plagniol-Villard, Peter Rosin,
linux-arm-kernel
Hi Peter,
On Sun, Oct 16, 2016 at 12:57:09PM +0200, Peter Rosin wrote:
> Hi again,
>
> I forgot about this, and it's been a year. But isn't it time to
> upstream those pull-up fixes that Sylvain provided?
Thank you for your reminder, actually I waited an answer on this nice
subject: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368643.html
But this is not relevant for this change anyway, if we should set a
pull-(up|down) on all push-pull pads to reduce power consumption it
should be enforced in the pinctrl driver, the dt must stay logical.
I just sent a v2 with all useless comments removed as suggested by
Alexandre and without the explanation about the removed extra power
consumption when removing a pull-(up|down) on a push-pull output because
it does even seem to be the contrary on Atmel SoCs.
Sylvain
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-16 16:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-24 14:44 [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx Peter Rosin
2015-09-24 14:47 ` Alexandre Belloni
[not found] ` <20150924144753.GY4287-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-09-24 15:22 ` Peter Rosin
2015-09-24 16:27 ` Alexandre Belloni
2016-10-16 10:57 ` Peter Rosin
2016-10-16 16:43 ` Sylvain Rochet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).