Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types

Luca Weiss
2022-09-26T16:13:09Z

On Montag, 26. September 2022 10:51:45 CEST Krzysztof Kozlowski wrote:
> On 25/09/2022 23:17, Luca Weiss wrote:
>
> Thank you for your patch. There is something to discuss/improve.
>
> > additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec
> > binding not converted yet>
> > + "charger@[0-9a-f]+$":
> > + type: object
> > + oneOf:
> > + - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> > + - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> > +
> > + "^dcdc@[0-9a-f]+$":
> > + type: object
>
> How about renaming this one to usb-vbus-regulator?

Sounds good to me. I was actually hoping somebody would suggest a better name.

Should I wait a bit to see if anybody else has a better suggestion or send a
v2 now?

Regards
Luca

>
> Best regards,
> Krzysztof