From: santosh shilimkar <santosh.shilimkar@oracle.com>
To: Nishanth Menon <nm@ti.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags
Date: Fri, 25 Sep 2015 08:18:07 -0700 [thread overview]
Message-ID: <560565AF.2010701@oracle.com> (raw)
In-Reply-To: <56055F1F.4060401@ti.com>
On 9/25/2015 7:50 AM, Nishanth Menon wrote:
> On 09/24/2015 10:54 AM, Murali Karicheri wrote:
> [...]
>> ti,omap3 is the family of omap3 devices similar to keystone. ti,omap3450
>> is required if there is an exceptional treatment required for ti,omap3450.
>>
>> In keystone case so far there is no case of exceptional treatment
>> required in the code for a specific SoC. So a generic name, ti,keystone
>> is used. When exceptional treatment is needed in the future, for example
>> k2hk Soc, we should introduce SoC specific string in the following order.
>
> Did you do a grep on the code to see?
> $ git grep ti,omap3 arch/arm/mach-omap2/
> arch/arm/mach-omap2/board-generic.c: "ti,omap3430",
> arch/arm/mach-omap2/board-generic.c: "ti,omap3",
> arch/arm/mach-omap2/board-generic.c: "ti,omap36xx",
> arch/arm/mach-omap2/board-generic.c: "ti,omap3-beagle",
>
> This is the same as keystone's device support. even though only 36xx was
> needed, we introduced other SoC specific compatibility match.
>
>> "ti,k2hk-evm", "ti,k2hk", "ti,keystone"
>>
>> So unless there is an exception, there is no need for a SoC specific
>> string in the compatibility string list. So this can be added later if
>> there is need for exceptional treatment. Did I get it wrong?
>>
>
> I see both your views seem to be "if we dont need a compatible" dont add
> it. My view was based on "be accurate in the hardware description"
>
> OK - i will probably agree on the topic. But, how about userspace
> needing to know which SoC they are on, without needing to depend on
> board->soc mapping? How do we help resolve that?
>
Why the user space should care about exact SOC ?
next prev parent reply other threads:[~2015-09-25 15:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 16:08 [PATCH 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches Nishanth Menon
2015-09-22 16:08 ` [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags Nishanth Menon
2015-09-23 18:05 ` Murali Karicheri
[not found] ` <5602E9F3.7020102-l0cyMroinI0@public.gmane.org>
2015-09-23 19:15 ` Nishanth Menon
[not found] ` <1442938118-4718-2-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2015-09-23 18:19 ` santosh shilimkar
2015-09-24 14:05 ` Murali Karicheri
[not found] ` <56040323.1080409-l0cyMroinI0@public.gmane.org>
2015-09-24 14:20 ` Nishanth Menon
2015-09-24 15:54 ` Murali Karicheri
[not found] ` <56041CA4.40208-l0cyMroinI0@public.gmane.org>
2015-09-25 14:50 ` Nishanth Menon
2015-09-25 15:18 ` santosh shilimkar [this message]
2015-09-25 16:01 ` Nishanth Menon
[not found] ` <56056FD9.5060000-l0cyMroinI0@public.gmane.org>
2015-09-25 16:15 ` santosh shilimkar
[not found] ` <56057319.9080104-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-25 17:38 ` Nishanth Menon
2015-10-02 16:09 ` santosh shilimkar
2015-10-03 23:44 ` Nishanth Menon
[not found] ` <5610685A.3070501-l0cyMroinI0@public.gmane.org>
2015-10-04 0:16 ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2015-09-30 14:31 ` Murali Karicheri
2015-09-22 16:08 ` [PATCH 2/3] ARM: keystone: Update compatible to have SoC specific matches Nishanth Menon
2015-09-22 16:08 ` [PATCH 3/3] ARM: dts: keystone: Update SoC specific compatible flags Nishanth Menon
[not found] ` <1442938118-4718-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2015-10-03 23:38 ` [PATCH V2 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches Nishanth Menon
[not found] ` <1443915530-15035-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2015-10-03 23:38 ` [PATCH V2 1/3] Documentation: dt: keystone: provide SoC specific compatible flags Nishanth Menon
2015-10-03 23:38 ` [PATCH V2 3/3] ARM: dts: keystone: Update " Nishanth Menon
2015-10-04 0:13 ` [PATCH V2 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2015-10-03 23:38 ` [PATCH V2 2/3] ARM: keystone: Update compatible to have SoC specific matches Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560565AF.2010701@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).