From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH 2/3] ARM: dts: sun6i: Turn on gmac on Colombus Date: Tue, 29 Sep 2015 22:10:20 +0200 Message-ID: <560AF02C.2010308@redhat.com> References: <1438960955-6551-1-git-send-email-hdegoede@redhat.com> <1438960955-6551-2-git-send-email-hdegoede@redhat.com> <20150819151754.GH30520@lukather> <55D5725F.6000106@redhat.com> <20150820221259.GM30520@lukather> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150820221259.GM30520@lukather> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Ripard Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 08/21/2015 12:12 AM, Maxime Ripard wrote: > On Thu, Aug 20, 2015 at 08:23:27AM +0200, Hans de Goede wrote: >> Hi, >> >> On 08/19/2015 05:17 PM, Maxime Ripard wrote: >>> On Fri, Aug 07, 2015 at 05:22:34PM +0200, Hans de Goede wrote: >>>> We've everything we need to support the gmac on Colombus, turn it on. >>>> >>>> Signed-off-by: Hans de Goede >>> >>> I recall that the phy was powered by one of the AXP221 regulators, >>> does it require some additional stuff (like a recent u-boot), or does >>> it just work and my memory is bad :) ? >> >> I think it just works, it MAY be connected to aldo1 but according to >> the git history for the u-boot defconfig that one is used for wifi not >> for the gmac, and we do not enable any other "spare" regulators in the >> u-boot config. >> >> I do not have any schematics, so no way to say for sure. >> >> I can confirm that the GMAC work fine with the latest u-boot >> master. Looking in the history we've always enabled ALDO1 >> on the Colombus in upstream u-boot, so this should all just work. > > Except that if it is the case, the DT was working fine with the stock > bootloader, and it doesn't anymore, while we have no way to upgrade > it. Ok, I've finally made some time to test this, the gmac works fine with aldo1 disabled, so I believe this patch can be merged as is. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html