From: Timur Tabi <timur-N01EOCouUvQ@public.gmane.org>
To: alex.popov-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver
Date: Thu, 1 Oct 2015 12:11:10 -0500 [thread overview]
Message-ID: <560D692E.1010309@tabi.org> (raw)
In-Reply-To: <560C5325.6070406-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
On 09/30/2015 04:24 PM, Alexander Popov wrote:
>> Can you test for "!cs" here instead?
>>
>>> + e = -EFAULT;
>>> + goto err_param;
>>> + }
>
> Unfortunately no: 0 is a valid value for Chip Select.
> Is it OK to leave it like that?
Yes.
>>> + lpbfifo.ram_bus_addr = sg_dma_address(&sg); /* For freeing later */
>>> + sg_dma_len(&sg) = lpbfifo.req->size;
>>
>> I don't think sg_dma_len() is meant to be used as an lvalue.
>
> I've double-checked and found many cases of such usage of this macro.
> It seems that I can't avoid it too.
Ok.
>> Driver code that has to parse #address-cells or #size-cells
>> is usually wrong.
>
> I would not call it "parsing", I just check whether the dts-file is good.
> Anyway, could you give me a clue how to do better?
You should use of_n_size_cells() and of_n_addr_cells().
--
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-01 17:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 17:28 [PATCH v3 0/3] powerpc/512x: add LocalPlus Bus FIFO device driver Alexander Popov
2015-09-24 17:28 ` [PATCH v3 1/3] " Alexander Popov
[not found] ` <1443115737-3948-2-git-send-email-alex.popov-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-09-25 1:01 ` Timur Tabi
[not found] ` <56049CD0.7080104-N01EOCouUvQ@public.gmane.org>
2015-09-28 13:13 ` Alexander Popov
[not found] ` <56093CE5.5070301-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-09-28 13:18 ` Timur Tabi
[not found] ` <56093E1D.4080008-N01EOCouUvQ@public.gmane.org>
2015-09-29 6:34 ` Alexander Popov
2015-09-30 21:24 ` Alexander Popov
[not found] ` <560C5325.6070406-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-10-01 17:11 ` Timur Tabi [this message]
2015-10-05 22:22 ` Alexander Popov
2015-09-24 17:28 ` [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO Alexander Popov
2015-09-25 0:18 ` Timur Tabi
2015-09-28 13:24 ` Alexander Popov
[not found] ` <56093F89.1020004-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-09-28 13:26 ` Timur Tabi
[not found] ` <5609401F.3010603-N01EOCouUvQ@public.gmane.org>
2015-09-29 6:35 ` Alexander Popov
2015-09-24 17:28 ` [PATCH v3 3/3] dmaengine: mpc512x: initialize with subsys_initcall() Alexander Popov
2015-09-25 0:16 ` Timur Tabi
2015-09-28 13:15 ` Alexander Popov
[not found] ` <1443115737-3948-4-git-send-email-alex.popov-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-10-07 14:17 ` Vinod Koul
2015-10-07 21:31 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D692E.1010309@tabi.org \
--to=timur-n01eocouuvq@public.gmane.org \
--cc=agust-ynQEQJNshbs@public.gmane.org \
--cc=alex.popov-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
--cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).