From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi Date: Thu, 8 Oct 2015 09:32:40 +0100 Message-ID: <56162A28.8000104@redhat.com> References: <1438532305-5884-1-git-send-email-public_timo.s@silentcreek.de> <20150818153631.GH2547@lukather> <20151005173957.B1BD16C8150E@dd34104.kasserver.com> <7hzizu924y.fsf@deeprootsystems.com> <20151007154918.D6F856C800D4@dd34104.kasserver.com> Reply-To: hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: monnier-CRDzTM1onBSWkKpYnGOUKg@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 10/07/2015 05:01 PM, Stefan Monnier wrote: >> @Maxime: How should we handle this? In its current form, the patch applies >> only to the BananaPi dts by overriding the inherited opp from the SoC dtsi. >> In an earlier discussion, it was said that this can be done, even though it >> might not be the most elegant approach. But then again, I think it >> shouldn't be necessary to change the opp in the sun7i-a20.dtsi for all A20 >> boards since this is - to my knowledge - the first and only report that an >> A20 board has stability issues at the lower voltages (although not too many >> boards use voltage scaling yet). > > IIUC this setting doesn't affect signals external to the A20, so it > seems like it should be board-agnostic. This setting configures the voltage at the pmic output pin, not at the SoC power-input pins. And how much of the voltage actually makes it from the pmic to the SoC definitely is board-specific. So we are going to need board-specific opp-s in some cases (like this one for example). Regards, Hans