* Re: [PATCH 1/3] docs: dts: Add documentation for hi6220 SoC ION node [not found] ` <1444632386-106627-1-git-send-email-puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> @ 2015-10-12 9:31 ` Mark Rutland 2015-10-13 6:26 ` chenfeng 0 siblings, 1 reply; 4+ messages in thread From: Mark Rutland @ 2015-10-12 9:31 UTC (permalink / raw) To: Chen Feng Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, arve-z5hGa2qSFaRBDgjK7y7TUQ, riandrews-z5hGa2qSFaRBDgjK7y7TUQ, tranmanphong-Re5JQEeQqe8AvxtiuMwx3w, mitchelh-sgV2jX0FEOL9JmXXK+q4OQ, dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA, tapaswenipathak-Re5JQEeQqe8AvxtiuMwx3w, sumit.semwal-QSEj5FYQhm4dnm+yROfE0A, yudongbin-C8/M+/jPZTeaMJb+Lgu22Q, saberlily.xia-C8/M+/jPZTeaMJb+Lgu22Q, suzhuangluan-C8/M+/jPZTeaMJb+Lgu22Q, kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q, xuyiping-C8/M+/jPZTeaMJb+Lgu22Q, z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q, puck.chen-H32Fclmsjq1BDgjK7y7TUQ, weidong2-C8/M+/jPZTeaMJb+Lgu22Q, w.f-hv44wF8Li93QT0dZR+AlfA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, qijiwen-C8/M+/jPZTeaMJb+Lgu22Q, peter.panshilin-C8/M+/jPZTeaMJb+Lgu22Q, dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q, linuxarm-hv44wF8Li93QT0dZR+AlfA, devicetree-u79uwXL29TY76Z2rM5mHXA, laura-0PSzFVTn/CLa5EbDDlwbIw On Mon, Oct 12, 2015 at 02:46:24PM +0800, Chen Feng wrote: > Documentation for hi6220 SoC ION node > > Signed-off-by: Chen Feng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> > Signed-off-by: Yu Dongbin <yudongbin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> > --- > .../devicetree/bindings/staging/ion/hi6220-ion.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt We should not be adding platform-specific bindings and/or drivers for this. There's already a proposal for a generic binding [1]. Please work with that rather than working on your own. Mark. [1] https://lkml.org/lkml/2015/10/6/854 > diff --git a/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt > new file mode 100644 > index 0000000..c59e27c > --- /dev/null > +++ b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt > @@ -0,0 +1,31 @@ > +Hi6220 SoC ION > +=================================================================== > +Required properties: > +- compatible : "hisilicon,hi6220-ion" > +- list of the ION heaps > + - heap name : maybe heap_sys_user@0 > + - heap id : id should be unique in the system. > + - heap base : base ddr address of the heap,0 means that > + it is dynamic. > + - heap size : memory size and 0 means it is dynamic. > + - heap type : the heap type of the heap, please also > + see the define in ion.h(drivers/staging/android/uapi/ion.h) > +------------------------------------------------------------------- > +Example: > + hi6220-ion { > + compatible = "hisilicon,hi6220-ion"; > + heap_sys_user@0 { > + heap-name = "sys_user"; > + heap-id = <0x0>; > + heap-base = <0x0>; > + heap-size = <0x0>; > + heap-type = "ion_system"; > + }; > + heap_sys_contig@0 { > + heap-name = "sys_contig"; > + heap-id = <0x1>; > + heap-base = <0x0>; > + heap-size = <0x0>; > + heap-type = "ion_system_contig"; > + }; > + }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] docs: dts: Add documentation for hi6220 SoC ION node 2015-10-12 9:31 ` [PATCH 1/3] docs: dts: Add documentation for hi6220 SoC ION node Mark Rutland @ 2015-10-13 6:26 ` chenfeng [not found] ` <561CA408.5060202-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: chenfeng @ 2015-10-13 6:26 UTC (permalink / raw) To: Mark Rutland Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, arve-z5hGa2qSFaRBDgjK7y7TUQ, riandrews-z5hGa2qSFaRBDgjK7y7TUQ, tranmanphong-Re5JQEeQqe8AvxtiuMwx3w, mitchelh-sgV2jX0FEOL9JmXXK+q4OQ, dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA, tapaswenipathak-Re5JQEeQqe8AvxtiuMwx3w, sumit.semwal-QSEj5FYQhm4dnm+yROfE0A, yudongbin-C8/M+/jPZTeaMJb+Lgu22Q, saberlily.xia-C8/M+/jPZTeaMJb+Lgu22Q, suzhuangluan-C8/M+/jPZTeaMJb+Lgu22Q, kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q, xuyiping-C8/M+/jPZTeaMJb+Lgu22Q, z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q, puck.chen-H32Fclmsjq1BDgjK7y7TUQ, weidong2-C8/M+/jPZTeaMJb+Lgu22Q, w.f-hv44wF8Li93QT0dZR+AlfA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, qijiwen-C8/M+/jPZTeaMJb+Lgu22Q, peter.panshilin-C8/M+/jPZTeaMJb+Lgu22Q, dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q, linuxarm-hv44wF8Li93QT0dZR+AlfA, devicetree-u79uwXL29TY76Z2rM5mHXA, laura-0PSzFVTn/CLa5EbDDlwbIw On 2015/10/12 17:31, Mark Rutland wrote: > On Mon, Oct 12, 2015 at 02:46:24PM +0800, Chen Feng wrote: >> Documentation for hi6220 SoC ION node >> >> Signed-off-by: Chen Feng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> >> Signed-off-by: Yu Dongbin <yudongbin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> >> --- >> .../devicetree/bindings/staging/ion/hi6220-ion.txt | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt > > > We should not be adding platform-specific bindings and/or drivers for > this. > > There's already a proposal for a generic binding [1]. Please work with > that rather than working on your own. > > Mark. > > [1] https://lkml.org/lkml/2015/10/6/854 Mark, I checked the patch in https://lkml.org/lkml/2015/10/6/854. It's a generic binding document for devicetree of ion. Should I just drop this document patch? Is the patch 2,3 for hisilicon ion ok for upstream? Please give me more help. Thanks very much. > >> diff --git a/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt >> new file mode 100644 >> index 0000000..c59e27c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt >> @@ -0,0 +1,31 @@ >> +Hi6220 SoC ION >> +=================================================================== >> +Required properties: >> +- compatible : "hisilicon,hi6220-ion" >> +- list of the ION heaps >> + - heap name : maybe heap_sys_user@0 >> + - heap id : id should be unique in the system. >> + - heap base : base ddr address of the heap,0 means that >> + it is dynamic. >> + - heap size : memory size and 0 means it is dynamic. >> + - heap type : the heap type of the heap, please also >> + see the define in ion.h(drivers/staging/android/uapi/ion.h) >> +------------------------------------------------------------------- >> +Example: >> + hi6220-ion { >> + compatible = "hisilicon,hi6220-ion"; >> + heap_sys_user@0 { >> + heap-name = "sys_user"; >> + heap-id = <0x0>; >> + heap-base = <0x0>; >> + heap-size = <0x0>; >> + heap-type = "ion_system"; >> + }; >> + heap_sys_contig@0 { >> + heap-name = "sys_contig"; >> + heap-id = <0x1>; >> + heap-base = <0x0>; >> + heap-size = <0x0>; >> + heap-type = "ion_system_contig"; >> + }; >> + }; >> -- >> 1.9.1 >> > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <561CA408.5060202-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>]
* Re: [PATCH 1/3] docs: dts: Add documentation for hi6220 SoC ION node [not found] ` <561CA408.5060202-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> @ 2015-10-13 20:42 ` Rob Herring [not found] ` <CAL_JsqJ=B_r2Cown=PEb4t8kkQLJMCvnx-x8sVv2k8UQAXOk3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Rob Herring @ 2015-10-13 20:42 UTC (permalink / raw) To: chenfeng Cc: Mark Rutland, Greg Kroah-Hartman, arve-z5hGa2qSFaRBDgjK7y7TUQ, Riley Andrews, tranmanphong-Re5JQEeQqe8AvxtiuMwx3w, Mitchel Humpherys, dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA, tapaswenipathak-Re5JQEeQqe8AvxtiuMwx3w, Sumit Semwal, yudongbin-C8/M+/jPZTeaMJb+Lgu22Q, saberlily.xia-C8/M+/jPZTeaMJb+Lgu22Q, suzhuangluan-C8/M+/jPZTeaMJb+Lgu22Q, Xinwei Kong, Yiping Xu, z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q, puck.chen-H32Fclmsjq1BDgjK7y7TUQ, weidong2-C8/M+/jPZTeaMJb+Lgu22Q, w.f-hv44wF8Li93QT0dZR+AlfA, Pawel Moll, Ian Campbell, Kumar Gala, qijiwen-C8/M+/jPZTeaMJb+Lgu22Q, shilin pan, dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q, linuxarm-hv44wF8Li93QT0dZR+AlfA, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Laura Abbott On Tue, Oct 13, 2015 at 1:26 AM, chenfeng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> wrote: > > > On 2015/10/12 17:31, Mark Rutland wrote: >> On Mon, Oct 12, 2015 at 02:46:24PM +0800, Chen Feng wrote: >>> Documentation for hi6220 SoC ION node >>> >>> Signed-off-by: Chen Feng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> >>> Signed-off-by: Yu Dongbin <yudongbin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> >>> --- >>> .../devicetree/bindings/staging/ion/hi6220-ion.txt | 31 ++++++++++++++++++++++ >>> 1 file changed, 31 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt >> >> >> We should not be adding platform-specific bindings and/or drivers for >> this. >> >> There's already a proposal for a generic binding [1]. Please work with >> that rather than working on your own. >> >> Mark. >> >> [1] https://lkml.org/lkml/2015/10/6/854 > > Mark, I checked the patch in https://lkml.org/lkml/2015/10/6/854. > > It's a generic binding document for devicetree of ion. > > Should I just drop this document patch? > > Is the patch 2,3 for hisilicon ion ok for upstream? > > Please give me more help. Thanks very much. Well, first we need to accept the documentation patch before this. I'm expecting at least some changes to the doc first. Rob > >> >>> diff --git a/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt >>> new file mode 100644 >>> index 0000000..c59e27c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt >>> @@ -0,0 +1,31 @@ >>> +Hi6220 SoC ION >>> +=================================================================== >>> +Required properties: >>> +- compatible : "hisilicon,hi6220-ion" >>> +- list of the ION heaps >>> + - heap name : maybe heap_sys_user@0 >>> + - heap id : id should be unique in the system. >>> + - heap base : base ddr address of the heap,0 means that >>> + it is dynamic. >>> + - heap size : memory size and 0 means it is dynamic. >>> + - heap type : the heap type of the heap, please also >>> + see the define in ion.h(drivers/staging/android/uapi/ion.h) >>> +------------------------------------------------------------------- >>> +Example: >>> + hi6220-ion { >>> + compatible = "hisilicon,hi6220-ion"; >>> + heap_sys_user@0 { >>> + heap-name = "sys_user"; >>> + heap-id = <0x0>; >>> + heap-base = <0x0>; >>> + heap-size = <0x0>; >>> + heap-type = "ion_system"; >>> + }; >>> + heap_sys_contig@0 { >>> + heap-name = "sys_contig"; >>> + heap-id = <0x1>; >>> + heap-base = <0x0>; >>> + heap-size = <0x0>; >>> + heap-type = "ion_system_contig"; >>> + }; >>> + }; >>> -- >>> 1.9.1 >>> >> >> . >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CAL_JsqJ=B_r2Cown=PEb4t8kkQLJMCvnx-x8sVv2k8UQAXOk3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 1/3] docs: dts: Add documentation for hi6220 SoC ION node [not found] ` <CAL_JsqJ=B_r2Cown=PEb4t8kkQLJMCvnx-x8sVv2k8UQAXOk3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-10-19 1:57 ` chenfeng 0 siblings, 0 replies; 4+ messages in thread From: chenfeng @ 2015-10-19 1:57 UTC (permalink / raw) To: Rob Herring Cc: Mark Rutland, Greg Kroah-Hartman, arve-z5hGa2qSFaRBDgjK7y7TUQ, Riley Andrews, tranmanphong-Re5JQEeQqe8AvxtiuMwx3w, Mitchel Humpherys, dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA, tapaswenipathak-Re5JQEeQqe8AvxtiuMwx3w, Sumit Semwal, yudongbin-C8/M+/jPZTeaMJb+Lgu22Q, saberlily.xia-C8/M+/jPZTeaMJb+Lgu22Q, suzhuangluan-C8/M+/jPZTeaMJb+Lgu22Q, Xinwei Kong, Yiping Xu, z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q, puck.chen-H32Fclmsjq1BDgjK7y7TUQ, weidong2-C8/M+/jPZTeaMJb+Lgu22Q, w.f-hv44wF8Li93QT0dZR+AlfA, Pawel Moll, Ian Campbell, Kumar Gala, qijiwen-C8/M+/jPZTeaMJb+Lgu22Q, shilin pan, dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q, linuxarm-hv44wF8Li93QT0dZR+AlfA, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, La On 2015/10/14 4:42, Rob Herring wrote: > On Tue, Oct 13, 2015 at 1:26 AM, chenfeng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> wrote: >> >> >> On 2015/10/12 17:31, Mark Rutland wrote: >>> On Mon, Oct 12, 2015 at 02:46:24PM +0800, Chen Feng wrote: >>>> Documentation for hi6220 SoC ION node >>>> >>>> Signed-off-by: Chen Feng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> >>>> Signed-off-by: Yu Dongbin <yudongbin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> >>>> --- >>>> .../devicetree/bindings/staging/ion/hi6220-ion.txt | 31 ++++++++++++++++++++++ >>>> 1 file changed, 31 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt >>> >>> >>> We should not be adding platform-specific bindings and/or drivers for >>> this. >>> >>> There's already a proposal for a generic binding [1]. Please work with >>> that rather than working on your own. >>> >>> Mark. >>> >>> [1] https://lkml.org/lkml/2015/10/6/854 >> >> Mark, I checked the patch in https://lkml.org/lkml/2015/10/6/854. >> >> It's a generic binding document for devicetree of ion. >> >> Should I just drop this document patch? >> >> Is the patch 2,3 for hisilicon ion ok for upstream? >> >> Please give me more help. Thanks very much. > > Well, first we need to accept the documentation patch before this. I'm > expecting at least some changes to the doc first. > > Rob > Rob, Thanks first, I am not sure that I have understood your and mark's opinions. I will change the document as the string defined in of-ion.c which is in https://lkml.org/lkml/2015/10/6/856 >> >>> >>>> diff --git a/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt >>>> new file mode 100644 >>>> index 0000000..c59e27c >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt >>>> @@ -0,0 +1,31 @@ >>>> +Hi6220 SoC ION >>>> +=================================================================== >>>> +Required properties: >>>> +- compatible : "hisilicon,hi6220-ion" >>>> +- list of the ION heaps >>>> + - heap name : maybe heap_sys_user@0 >>>> + - heap id : id should be unique in the system. >>>> + - heap base : base ddr address of the heap,0 means that >>>> + it is dynamic. >>>> + - heap size : memory size and 0 means it is dynamic. >>>> + - heap type : the heap type of the heap, please also >>>> + see the define in ion.h(drivers/staging/android/uapi/ion.h) >>>> +------------------------------------------------------------------- >>>> +Example: >>>> + hi6220-ion { >>>> + compatible = "hisilicon,hi6220-ion"; >>>> + heap_sys_user@0 { >>>> + heap-name = "sys_user"; >>>> + heap-id = <0x0>; >>>> + heap-base = <0x0>; >>>> + heap-size = <0x0>; >>>> + heap-type = "ion_system"; >>>> + }; >>>> + heap_sys_contig@0 { >>>> + heap-name = "sys_contig"; >>>> + heap-id = <0x1>; >>>> + heap-base = <0x0>; >>>> + heap-size = <0x0>; >>>> + heap-type = "ion_system_contig"; >>>> + }; >>>> + }; >>>> -- >>>> 1.9.1 >>>> >>> >>> . >>> >> > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-19 1:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1444632386-106627-1-git-send-email-puck.chen@hisilicon.com>
[not found] ` <1444632386-106627-1-git-send-email-puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2015-10-12 9:31 ` [PATCH 1/3] docs: dts: Add documentation for hi6220 SoC ION node Mark Rutland
2015-10-13 6:26 ` chenfeng
[not found] ` <561CA408.5060202-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2015-10-13 20:42 ` Rob Herring
[not found] ` <CAL_JsqJ=B_r2Cown=PEb4t8kkQLJMCvnx-x8sVv2k8UQAXOk3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-19 1:57 ` chenfeng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).