devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Charles Keepax
	<ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org
Subject: Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection
Date: Tue, 13 Oct 2015 19:11:57 +0900	[thread overview]
Message-ID: <561CD8ED.7030004@samsung.com> (raw)
In-Reply-To: <20151013080350.GW17172@x1>

On 2015년 10월 13일 17:03, Lee Jones wrote:
> On Mon, 12 Oct 2015, Chanwoo Choi wrote:
> 
>> On 2015년 10월 12일 19:16, Chanwoo Choi wrote:
>>> Hi Charles,
>>>
>>> On 2015년 10월 12일 17:45, Charles Keepax wrote:
>>>> On Wed, Oct 07, 2015 at 01:26:42PM +0100, Lee Jones wrote:
>>>>> On Wed, 07 Oct 2015, Mark Brown wrote:
>>>>>
>>>>>> On Fri, Oct 02, 2015 at 05:29:22PM +0100, Charles Keepax wrote:
>>>>>>> Add additional bindings to allow configuration of the system specific
>>>>>>> microphone detection settings.
>>>>>>
>>>>>> This all seems pretty much fine to me - the things it is controlling are
>>>>>> fairly specific to the way the former Wolfson devices do, they only
>>>>>> really make sense with a fairly particular algorithm which isn't widely
>>>>>> implemented.
>>>>>
>>>>> Is that an Ack?
>>>>
>>>> I am guessing Mark is slightly hesitant to ack as he probably
>>>> doesn't want to add reviewing all our jack detection bindings to
>>>> his already fairly sizable work load and doing so here likely
>>>> means it will be expected in the future. From talking to people at
>>>> LinuxCon it looks like it is pretty unlikely the DT maintainers
>>>> will be acking individual bindings as well, basically they are
>>>> only really looking at major/framework things and leaving the
>>>> rest to subsystem maintainers.
>>>>
>>>> Given that these patches only touch MFD/Extcon and extcon
>>>> is a subsystem designed to handle things like jack detection
>>>> isn't it really sufficient that you and Chanwoo have looked this
>>>> and are happy with it? Otherwise I really don't see anyway to
>>>> move this forward and would appreciate any suggestions?
>>>
>>> I'm positive about your patches. After receiving the ack from MFD maintainer
>>> I want to apply this patch-set on extcon git repository.
>>>
>>> Also, I reviewed this patch on previous patch[1].
>>> [1]https://lkml.org/lkml/2015/9/11/81
>>
>> As you said, this patch touch MFD and EXTCON subsystem.
>> If you get the Ack or agreement from MFD maintainer,
>> I'm willing to apply it on extcon git.
>>
>> Also, If this patch dont receive the additional ack message
>> unitl the end of this week, I'll merge patch1-3 on extcon-next branch
>> for Linux 4.4.
> 
> Absolutely not!
> 
> I should be extremely cross if you 'go over my head' and apply MFD
> patches without the correct Acks.
> 

Just I mean that if there is any reply or opinion about patch.
But, You're right. It is misconception of me. We should check them cross before applying them.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-10-13 10:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 16:29 [PATCH v2 0/5] Arizona Extcon Update Device Bindings Charles Keepax
     [not found] ` <1443803363-3251-1-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-10-02 16:29   ` [PATCH v2 1/5] extcon: arizona: Add device binding to enable ADC mode micdet Charles Keepax
2015-10-02 16:29 ` [PATCH v2 2/5] extcon: arizona: Add device binding for the general purpose switch Charles Keepax
2015-10-02 16:29 ` [PATCH v2 3/5] extcon: arizona: Add device binding for jack detect polarity inversion Charles Keepax
2015-10-02 16:29 ` [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection Charles Keepax
2015-10-05 10:02   ` Lee Jones
2015-10-07 10:00   ` Mark Brown
     [not found]     ` <20151007100017.GB12635-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-07 12:26       ` Lee Jones
2015-10-12  8:45         ` Charles Keepax
2015-10-12 10:16           ` Chanwoo Choi
2015-10-12 10:25             ` Chanwoo Choi
2015-10-13  8:03               ` Lee Jones
2015-10-13 10:11                 ` Chanwoo Choi [this message]
2015-10-12 13:43           ` Mark Brown
     [not found]             ` <20151012134309.GE1542-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-13  8:02               ` Lee Jones
2015-10-13 12:14                 ` Charles Keepax
2015-10-13 13:50                   ` Lee Jones
2015-10-13 13:59                     ` Chanwoo Choi
     [not found]                       ` <561D0E4C.4010205-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-13 14:09                         ` Chanwoo Choi
2015-10-13 14:18                           ` Lee Jones
2015-10-13 15:23                             ` Charles Keepax
2015-10-13 15:12                 ` Mark Brown
2015-10-14  7:28                   ` Lee Jones
2015-10-14  9:49                     ` Mark Brown
     [not found]                       ` <20151014094903.GP14956-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-14 12:30                         ` Lee Jones
2015-10-14 13:09                           ` Mark Brown
2015-10-14 13:20                             ` Lee Jones
2015-10-13  8:08   ` Lee Jones
2015-10-13 12:15     ` Charles Keepax
2015-10-13 13:43       ` Lee Jones
2015-10-02 16:29 ` [PATCH v2 5/5] mfd: arizona: Update DT binding document for jack detection invert Charles Keepax
2015-10-05 10:01   ` Lee Jones
2015-10-12  8:15     ` Charles Keepax
2015-10-13  8:07       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561CD8ED.7030004@samsung.com \
    --to=cw00.choi-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).