From: Ray Jui <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
To: Jon Mason <jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>,
Scott Branden <sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org
Subject: Re: [RFC 4/5] clk: iproc: define Broadcom NS2 iProc clock binding
Date: Tue, 13 Oct 2015 15:24:52 -0700 [thread overview]
Message-ID: <561D84B4.4000002@broadcom.com> (raw)
In-Reply-To: <1444771347-11382-5-git-send-email-jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Same as this patch. I thought device tree binding document should go
with the clock driver changes.
Strictly speaking, device tree binding document should always go before
the driver changes. In the binding document the DT interface is defined,
then changes are implemented in the driver.
Ray
On 10/13/2015 2:22 PM, Jon Mason wrote:
> Document the device tree bindings for Broadcom Northstar 2 architecture
> based clock controller
>
> Signed-off-by: Jon Mason <jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> ---
> .../bindings/clock/brcm,iproc-clocks.txt | 48 ++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt
> index b3c3e9d..ede65a5 100644
> --- a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt
> +++ b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt
> @@ -160,3 +160,51 @@ Northstar Plus. These clock IDs are defined in:
> pcie_phy lcpll0 1 BCM_NSP_LCPLL0_PCIE_PHY_REF_CLK
> sdio lcpll0 2 BCM_NSP_LCPLL0_SDIO_CLK
> ddr_phy lcpll0 3 BCM_NSP_LCPLL0_DDR_PHY_CLK
> +
> +Northstar 2
> +-----------
> +PLL and leaf clock compatible strings for Northstar 2 are:
> + "brcm,ns2-genpll-scr"
> + "brcm,ns2-genpll-sw"
> + "brcm,ns2-lcpll-ddr"
> + "brcm,ns2-lcpll-ports"
> +
> +The following table defines the set of PLL/clock index and ID for Northstar 2.
> +These clock IDs are defined in:
> + "include/dt-bindings/clock/bcm-ns2.h"
> +
> + Clock Source Index ID
> + --- ----- ----- ---------
> + crystal N/A N/A N/A
> +
> + genpll_scr crystal 0 BCM_NS2_GENPLL_SCR
> + scr genpll_scr 1 BCM_NS2_GENPLL_SCR_SCR_CLK
> + fs genpll_scr 2 BCM_NS2_GENPLL_SCR_FS_CLK
> + audio_ref genpll_scr 3 BCM_NS2_GENPLL_SCR_AUDIO_CLK
> + ch3_unused genpll_scr 4 BCM_NS2_GENPLL_SCR_CH3_UNUSED
> + ch4_unused genpll_scr 5 BCM_NS2_GENPLL_SCR_CH4_UNUSED
> + ch5_unused genpll_scr 6 BCM_NS2_GENPLL_SCR_CH5_UNUSED
> +
> + genpll_sw crystal 0 BCM_NS2_GENPLL_SW
> + rpe genpll_sw 1 BCM_NS2_GENPLL_SW_RPE_CLK
> + 250 genpll_sw 2 BCM_NS2_GENPLL_SW_250_CLK
> + nic genpll_sw 3 BCM_NS2_GENPLL_SW_NIC_CLK
> + chimp genpll_sw 4 BCM_NS2_GENPLL_SW_CHIMP_CLK
> + port genpll_sw 5 BCM_NS2_GENPLL_SW_PORT_CLK
> + sdio genpll_sw 6 BCM_NS2_GENPLL_SW_SDIO_CLK
> +
> + lcpll_ddr crystal 0 BCM_NS2_LCPLL_DDR
> + pcie_sata_usb lcpll_ddr 1 BCM_NS2_LCPLL_DDR_PCIE_SATA_USB_CLK
> + ddr lcpll_ddr 2 BCM_NS2_LCPLL_DDR_DDR_CLK
> + ch2_unused lcpll_ddr 3 BCM_NS2_LCPLL_DDR_CH2_UNUSED
> + ch3_unused lcpll_ddr 4 BCM_NS2_LCPLL_DDR_CH3_UNUSED
> + ch4_unused lcpll_ddr 5 BCM_NS2_LCPLL_DDR_CH4_UNUSED
> + ch5_unused lcpll_ddr 6 BCM_NS2_LCPLL_DDR_CH5_UNUSED
> +
> + lcpll_ports crystal 0 BCM_NS2_LCPLL_PORTS
> + wan lcpll_ports 1 BCM_NS2_LCPLL_PORTS_WAN_CLK
> + rgmii lcpll_ports 2 BCM_NS2_LCPLL_PORTS_RGMII_CLK
> + ch2_unused lcpll_ports 3 BCM_NS2_LCPLL_PORTS_CH2_UNUSED
> + ch3_unused lcpll_ports 4 BCM_NS2_LCPLL_PORTS_CH3_UNUSED
> + ch4_unused lcpll_ports 5 BCM_NS2_LCPLL_PORTS_CH4_UNUSED
> + ch5_unused lcpll_ports 6 BCM_NS2_LCPLL_PORTS_CH5_UNUSED
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-13 22:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 21:22 [PATCH 0/5] ARM: dts: add device tree support for NS, NSP, and NS2 clocks Jon Mason
2015-10-13 21:22 ` [RFC 1/5] clk: iproc: define Broadcom NSP iProc clock binding Jon Mason
2015-10-13 22:17 ` Ray Jui
[not found] ` <561D8300.3040804-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-14 15:40 ` Jon Mason
2015-10-13 21:22 ` [RFC 2/5] ARM: dts: enable clock support for Broadcom NSP Jon Mason
2015-10-13 21:22 ` [RFC 3/5] ARM: dts: enable clock support for BCM5301X Jon Mason
2015-10-18 22:34 ` Hauke Mehrtens
2015-10-13 21:22 ` [RFC 4/5] clk: iproc: define Broadcom NS2 iProc clock binding Jon Mason
[not found] ` <1444771347-11382-5-git-send-email-jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-13 22:24 ` Ray Jui [this message]
[not found] ` <561D84B4.4000002-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-14 15:44 ` Jon Mason
[not found] ` <20151014154410.GF15160-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-14 16:53 ` Ray Jui
2015-10-16 22:11 ` Stephen Boyd
2015-10-13 21:22 ` [RFC 5/5] ARM: dts: enable clock support for Broadcom NS2 Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D84B4.4000002@broadcom.com \
--to=rjui-dy08kvg/lbpwk0htik3j/w@public.gmane.org \
--cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org \
--cc=jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).