From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v4 3/3] arm64: dts: mt8173: Add nor flash node Date: Wed, 14 Oct 2015 14:05:17 +0300 Message-ID: <561E36ED.7090103@cogentembedded.com> References: <1444729160-26433-1-git-send-email-bayi.cheng@mediatek.com> <1444729160-26433-4-git-send-email-bayi.cheng@mediatek.com> <561D1642.3070105@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Kurtz Cc: Bayi Cheng , David Woodhouse , Brian Norris , Mark Rutland , "open list:OPEN FIRMWARE AND..." , srv_heupstream , Pawel Moll , Ian Campbell , Sascha Hauer , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kumar Gala , Matthias Brugger , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org Hello. On 10/14/2015 4:07 AM, Daniel Kurtz wrote: >>> Add Mediatek nor flash node >>> >>> Signed-off-by: Bayi Cheng >>> --- >>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> index d18ee42..385c2e4 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> @@ -365,6 +365,21 @@ >>> status = "disabled"; >>> }; >>> >>> + nor_flash: spi@1100d000 { >> >> I don't think this is a good label name for a SPI controller. > > You think "spi" is not a good name for SPI controller? > Or you mean the label "nor_flash"? I think I said clearly: "label". :-) > Would you prefer: > > spi_nor_flash: spi@1100d000 I'd prefer the "_nor_flash" part to be dropped, to be used for the real flash device (if needed) which is a sub-node of this node. [...] > -Dan MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html