From: "Franklin S Cooper Jr." <fcooper@ti.com>
To: Roger Quadros <rogerq@ti.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
nsekhar@ti.com, computersforpeace@gmail.com, dwmw2@infradead.org,
tony@atomide.com
Subject: Re: [PATCH 4/5] ARM: dts: am437x/am33xx/omap3/dm816x: Add gpmc dma channel
Date: Wed, 14 Oct 2015 08:57:04 -0500 [thread overview]
Message-ID: <561E5F30.80302@ti.com> (raw)
In-Reply-To: <561E4019.7090904@ti.com>
On 10/14/2015 06:44 AM, Roger Quadros wrote:
> On 13/10/15 04:38, Franklin S Cooper Jr wrote:
>> Add dma channel information to the gpmc. Although not enabled by
>> default this will allow prefetch-dma to be used.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> ---
>> arch/arm/boot/dts/am33xx.dtsi | 2 ++
>> arch/arm/boot/dts/am4372.dtsi | 2 ++
>> arch/arm/boot/dts/dm816x.dtsi | 2 ++
>> arch/arm/boot/dts/omap3.dtsi | 2 ++
> How about fixing up omap4/5 and dra7 as well?
Shouldn't be a problem for omap4 and omap5.
Dra7 with sdma can't support this feature. With edma it works fine. So I'll
wait until edma support for dra7 makes it into mainline and then I can send
a new patch adding support.
>
> cheers,
> -roger
>
>> 4 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index e065f21..f2d8eed 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -819,6 +819,8 @@
>> ti,no-idle-on-init;
>> reg = <0x50000000 0x2000>;
>> interrupts = <100>;
>> + dmas = <&edma 52>;
>> + dma-names = "rxtx";
>> gpmc,num-cs = <7>;
>> gpmc,num-waitpins = <2>;
>> #address-cells = <2>;
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ec8b7a3..c02061b 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -841,6 +841,8 @@
>> gpmc: gpmc@50000000 {
>> compatible = "ti,am3352-gpmc";
>> ti,hwmods = "gpmc";
>> + dmas = <&edma 52>;
>> + dma-names = "rxtx";
>> clocks = <&l3s_gclk>;
>> clock-names = "fck";
>> reg = <0x50000000 0x2000>;
>> diff --git a/arch/arm/boot/dts/dm816x.dtsi b/arch/arm/boot/dts/dm816x.dtsi
>> index 68fb444..d2e5d31 100644
>> --- a/arch/arm/boot/dts/dm816x.dtsi
>> +++ b/arch/arm/boot/dts/dm816x.dtsi
>> @@ -180,6 +180,8 @@
>> #address-cells = <2>;
>> #size-cells = <1>;
>> interrupts = <100>;
>> + dmas = <&edma 52>;
>> + dma-names = "rxtx";
>> gpmc,num-cs = <6>;
>> gpmc,num-waitpins = <2>;
>> gpio-controller;
>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>> index 7f212b6..9dbbcf6 100644
>> --- a/arch/arm/boot/dts/omap3.dtsi
>> +++ b/arch/arm/boot/dts/omap3.dtsi
>> @@ -717,6 +717,8 @@
>> ti,hwmods = "gpmc";
>> reg = <0x6e000000 0x02d0>;
>> interrupts = <20>;
>> + dmas = <&sdma 4>;
>> + dma-names = "rxtx";
>> gpmc,num-cs = <8>;
>> gpmc,num-waitpins = <4>;
>> #address-cells = <2>;
>>
next prev parent reply other threads:[~2015-10-14 13:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 1:38 [PATCH 0/5] mtd: nand: Fix support for NAND DMA Prefetch Franklin S Cooper Jr
2015-10-13 1:38 ` [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Franklin S Cooper Jr
2015-10-14 11:36 ` Roger Quadros
2015-10-14 11:52 ` Roger Quadros
2015-10-14 13:26 ` Franklin S Cooper Jr.
2015-10-14 14:11 ` Roger Quadros
[not found] ` <561E629F.5070202-l0cyMroinI0@public.gmane.org>
2015-10-14 14:32 ` Franklin S Cooper Jr.
[not found] ` <561E6791.3030404-l0cyMroinI0@public.gmane.org>
2015-10-14 16:18 ` Tony Lindgren
[not found] ` <20151014161813.GC10113-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-10-14 16:23 ` Franklin S Cooper Jr.
2015-10-14 18:13 ` Tony Lindgren
[not found] ` <20151014181337.GF10113-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-10-14 20:03 ` Franklin S Cooper Jr.
2015-10-15 7:35 ` Roger Quadros
2015-10-15 17:12 ` Franklin S Cooper Jr.
2015-10-13 1:38 ` [PATCH 2/5] mtd: nand: omap2: Start dma request before enabling prefetch Franklin S Cooper Jr
2015-10-14 11:41 ` Roger Quadros
[not found] ` <561E3F5B.6040102-l0cyMroinI0@public.gmane.org>
2015-10-14 13:45 ` Franklin S Cooper Jr.
2015-10-13 1:38 ` [PATCH 3/5] mtd: nand: omap2: Fix high memory dma prefetch transfer Franklin S Cooper Jr
2015-10-13 1:38 ` [PATCH 4/5] ARM: dts: am437x/am33xx/omap3/dm816x: Add gpmc dma channel Franklin S Cooper Jr
2015-10-14 11:44 ` Roger Quadros
2015-10-14 13:57 ` Franklin S Cooper Jr. [this message]
2015-10-13 1:38 ` [PATCH 5/5] ARM: OMAP2+: Update gpmc and nand DT binding documentation Franklin S Cooper Jr
2015-10-14 11:50 ` Roger Quadros
2015-10-15 17:14 ` Franklin S Cooper Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561E5F30.80302@ti.com \
--to=fcooper@ti.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).