[PATCH 0/1] Fix for module license in Broadcom Phy Library

[PATCH 0/1] Fix for module license in Broadcom Phy Library

[Arun Parameswaran]

Hi
This patchset adds the module description, license & author to the
Broadcom Phy Library (drivers/net/phy/bcm-phy-lib.c) introduced by
the commit: a1cba5613edf5 ("net: phy: Add Broadcom phy library for
common interfaces")

Arun Parameswaran (1):
  net: phy: bcm-phy-lib: Fix module license issue

 drivers/net/phy/bcm-phy-lib.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.6.1

[PATCH 1/1] net: phy: bcm-phy-lib: Fix module license issue

[Arun Parameswaran]

The 'bcm-phy-lib.c', added as a part of the commit
"net: phy: Add Broadcom phy library for common interfaces"
was missing the module license. This was causing an issue
when the library is built as a module; "module license
'unspecified' taints kernel".

This patch fixes the issue by adding the module license,
author and description to the bcm-phy-lib.c file.

Fixes: a1cba5613edf5 ("net: phy: Add Broadcom phy library for common
interfaces")
Signed-off-by: Arun Parameswaran <arunp@broadcom.com>
---
 drivers/net/phy/bcm-phy-lib.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c
index 13e161e..ddb377e 100644
--- a/drivers/net/phy/bcm-phy-lib.c
+++ b/drivers/net/phy/bcm-phy-lib.c
@@ -15,6 +15,7 @@
 #include <linux/brcmphy.h>
 #include <linux/export.h>
 #include <linux/mdio.h>
+#include <linux/module.h>
 #include <linux/phy.h>
 
 #define MII_BCM_CHANNEL_WIDTH     0x2000
@@ -207,3 +208,6 @@ int bcm_phy_enable_eee(struct phy_device *phydev)
 }
 EXPORT_SYMBOL_GPL(bcm_phy_enable_eee);
 
+MODULE_DESCRIPTION("Broadcom PHY Library");
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Broadcom Corporation");
-- 
2.6.1

Re: [PATCH 1/1] net: phy: bcm-phy-lib: Fix module license issue

[David Miller]

From: Arun Parameswaran <arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Date: Tue, 13 Oct 2015 13:40:12 -0700

> The 'bcm-phy-lib.c', added as a part of the commit
> "net: phy: Add Broadcom phy library for common interfaces"
> was missing the module license. This was causing an issue
> when the library is built as a module; "module license
> 'unspecified' taints kernel".
> 
> This patch fixes the issue by adding the module license,
> author and description to the bcm-phy-lib.c file.
> 
> Fixes: a1cba5613edf5 ("net: phy: Add Broadcom phy library for common
> interfaces")
> Signed-off-by: Arun Parameswaran <arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

This patch doesn't apply to my net-next tree at all.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] net: phy: bcm-phy-lib: Fix module license issue

[Arun Parameswaran]

On 15-10-14 06:39 PM, David Miller wrote:
> From: Arun Parameswaran <arunp@broadcom.com>
> Date: Tue, 13 Oct 2015 13:40:12 -0700
>
>> The 'bcm-phy-lib.c', added as a part of the commit
>> "net: phy: Add Broadcom phy library for common interfaces"
>> was missing the module license. This was causing an issue
>> when the library is built as a module; "module license
>> 'unspecified' taints kernel".
>>
>> This patch fixes the issue by adding the module license,
>> author and description to the bcm-phy-lib.c file.
>>
>> Fixes: a1cba5613edf5 ("net: phy: Add Broadcom phy library for common
>> interfaces")
>> Signed-off-by: Arun Parameswaran <arunp@broadcom.com>
> This patch doesn't apply to my net-next tree at all.

There is a mismatch in the 'git diff' output, for the last 3 lines in
bcm-phy-lib.c

For some reason the patch I created has '@@ -207,3 +208,6 @@', instead of
'@@ -206,3 +207,7 @@', when created from the 'net-next'.

I will send out a patch based on the 'net-next'.

Thanks
Arun