devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Arun Parameswaran <arunp@broadcom.com>,
	"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue
Date: Thu, 15 Oct 2015 10:39:26 -0700	[thread overview]
Message-ID: <561FE4CE.2030101@gmail.com> (raw)
In-Reply-To: <1444930633-23314-2-git-send-email-arunp@broadcom.com>

On 15/10/15 10:37, Arun Parameswaran wrote:
> The 'bcm-phy-lib.c', added as a part of the commit
> "net: phy: Add Broadcom phy library for common interfaces"
> was missing the module license. This was causing an issue
> when the library is built as a module; "module license
> 'unspecified' taints kernel".
> 
> This patch fixes the issue by adding the module license,
> author and description to the bcm-phy-lib.c file.
> 
> Fixes: a1cba5613edf5 ("net: phy: Add Broadcom phy library for
> common interfaces")

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

> Signed-off-by: Arun Parameswaran <arunp@broadcom.com>
> ---
>  drivers/net/phy/bcm-phy-lib.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c
> index dd79ea6..ddb377e 100644
> --- a/drivers/net/phy/bcm-phy-lib.c
> +++ b/drivers/net/phy/bcm-phy-lib.c
> @@ -15,6 +15,7 @@
>  #include <linux/brcmphy.h>
>  #include <linux/export.h>
>  #include <linux/mdio.h>
> +#include <linux/module.h>
>  #include <linux/phy.h>
> 
>  #define MII_BCM_CHANNEL_WIDTH     0x2000
> @@ -206,3 +207,7 @@ int bcm_phy_enable_eee(struct phy_device *phydev)
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(bcm_phy_enable_eee);
> +
> +MODULE_DESCRIPTION("Broadcom PHY Library");
> +MODULE_LICENSE("GPL v2");
> +MODULE_AUTHOR("Broadcom Corporation");
> --
> 2.6.1
> 


-- 
Florian

  reply	other threads:[~2015-10-15 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 17:37 [PATCH v2 0/1] Fix for module license in Broadcom Phy Library Arun Parameswaran
2015-10-15 17:37 ` [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue Arun Parameswaran
2015-10-15 17:39   ` Florian Fainelli [this message]
     [not found]   ` <1444930633-23314-2-git-send-email-arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-19  2:35     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561FE4CE.2030101@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=arunp@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).