From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>, linux-kernel@vger.kernel.org
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kukjin Kim <kgene@kernel.org>, Inki Dae <inki.dae@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: dts: exynos5250: Add clocks to DISP1 domain
Date: Fri, 16 Oct 2015 08:44:52 +0900 [thread overview]
Message-ID: <56203A74.7040305@samsung.com> (raw)
In-Reply-To: <1444905084-22540-3-git-send-email-tomeu.vizoso@collabora.com>
On 15.10.2015 19:31, Tomeu Vizoso wrote:
> Adds to the node of the DISP1 power domain the two clocks that need to
> be reparented while the domain is powered off:
> CLK_MOUT_ACLK200_DISP1_SUB and CLK_MOUT_ACLK300_DISP1_SUB.
>
> Otherwise the state is unknown at power up and the mixer's clocks are
> all messed up.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Link: http://lkml.kernel.org/g/561CDC33.7050103@collabora.com
> ---
>
>
> arch/arm/boot/dts/exynos5250.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index b24610ea8c2a..88b9cf5f226f 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -130,6 +130,10 @@
> compatible = "samsung,exynos4210-pd";
> reg = <0x100440A0 0x20>;
> #power-domain-cells = <0>;
> + clocks = <&clock CLK_FIN_PLL>,
> + <&clock CLK_MOUT_ACLK200_DISP1_SUB>,
> + <&clock CLK_MOUT_ACLK300_DISP1_SUB>;
> + clock-names = "oscclk", "clk0", "clk1";
> };
>
> clock: clock-controller@10010000 {
>
I reviewed it already. Any changes here since v1?
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-15 23:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 10:31 [PATCH v2 0/2] Fix display on second resume on 5250-snow Tomeu Vizoso
2015-10-15 10:31 ` [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Tomeu Vizoso
2015-10-15 23:46 ` Krzysztof Kozlowski
[not found] ` <56203AD3.2050905-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-16 12:49 ` Michael Turquette
2015-10-16 17:26 ` Stephen Boyd
2015-10-16 18:56 ` Tomeu Vizoso
2015-10-16 23:41 ` Kukjin Kim
2015-10-17 8:53 ` Krzysztof Kozlowski
[not found] ` <CAJKOXPf5Dnh36rrY6Vet13EHKB3gJuU0VnAfsyYnvWTx92O_GA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-17 9:55 ` Javier Martinez Canillas
2015-10-17 10:08 ` Krzysztof Kozlowski
2015-10-15 10:31 ` [PATCH v2 2/2] ARM: dts: exynos5250: Add clocks to DISP1 domain Tomeu Vizoso
2015-10-15 23:44 ` Krzysztof Kozlowski [this message]
2015-10-16 8:19 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56203A74.7040305@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).