From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: Add idle-states to device tree for rk3399 Date: Thu, 09 Aug 2018 22:09:42 +0200 Message-ID: <5620784.b19SH5PkdR@phil> References: <1467793254-10808-1-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1467793254-10808-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Caesar Wang Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Brian Norris , Xing Zheng , Masahiro Yamada , Catalin Marinas , dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Will Deacon , dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Rob Herring , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, tony.xie-TNX95d0MmH7DzftRWevZcw@public.gmane.org, David Wu , cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Jianqun Xu , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Am Mittwoch, 6. Juli 2016, 10:20:54 CEST schrieb Caesar Wang: > As the rk3399 ATF had been supported on ARM github [0], so we can add > idle-states for rk3399. > This patch adds idle-states bindings data collected through tests > experiments (latency and energy consumption) on rk3399 evb2 board. > > You can see detail idle-states definitions on document [1]. > > * arm,psci-suspend-param: power_state parameter to pass to the PSCI > suspend call. > * entry-latency: Worst case latency required to enter the idle state. The > exit-latency may be guaranteed only after entry-latency has passed. > * min-residency: Minimum period, including preparation and entry, for a > given idle state to be worthwhile energywise > * min-residency: Minimum period, including preparation and entry, for a > given idle state to be worthwhile energywise. > > [0]: > https://github.com/ARM-software/arm-trusted-firmware > [1]: > Documentation/devicetree/bindings/arm/psci.txt > Documentation/devicetree/bindings/arm/idle-states.txt > > Signed-off-by: Caesar Wang Looks like this patch slipped through the cracks and nobody reposted them over time. > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index a6dd623..12ce265 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -101,6 +101,18 @@ > }; > }; > > + idle-states { > + entry-method = "psci"; > + cpu_sleep: cpu-sleep-0 { > + compatible = "arm,idle-state"; > + local-timer-stop; > + arm,psci-suspend-param = <0x0010000>; > + entry-latency-us = <350>; > + exit-latency-us = <600>; > + min-residency-us = <1150>; Looking at the chromeos kernel, there are some more patches adapting this idle-state to use different timings. There also was a cluster-idle state added for a while but that seems to cause audio issues according to the CrOS history. In any case, I'll try to look at this shortly. Heiko